Initial code commit #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankowitz
force-pushed
the
feature/initial-code
branch
30 times, most recently
from
e085cd2
to
780c78b
Compare
brendankowitz
force-pushed
the
feature/initial-code
branch
8 times, most recently
from
37fa137
to
96b0951
Compare
brendankowitz
force-pushed
the
feature/initial-code
branch
from
96b0951
to
6c91968
Compare
BoyaWu10
pushed a commit
to BoyaWu10/fhir-server
that referenced
this pull request
May 26, 2020
Moria97 patch 1
shmartel
added a commit
that referenced
this pull request
Jun 23, 2020
* Handle all BYOK errors from Cosmos DB * Addressed PR comments * Moved CustomerManagedKeyException into Microsoft.Health.Fhir.CosmosDb * Revert "Moved CustomerManagedKeyException into Microsoft.Health.Fhir.CosmosDb" This reverts commit 0122a1e. * Address PR comments * Reverting code to commit #2 of this branch (792fcd6), and also resolve a couple PR comments * Remove circular reference by moving KnownCosmosDbCmkSubStatusValue into Core. * Fix build error * - per offline feedback, move the code that determines the CMK error message from Core and into CosmosDb. This removes any Cosmos-related knownledge from Core - Cosmos DB has published documentation on BYOK substatus codes: https://docs.microsoft.com/en-us/rest/api/cosmos-db/http-status-codes-for-cosmosdb. Updating Resources to better aligned with the Cosmos wording. * Fix spacing changes accidentally included in previous commit. * CMK exception should call base ctor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.