-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bulk delete enhancements #3505
Bulk delete enhancements #3505
Conversation
/azp run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple changes around rest file / operation definitions. Others are responses to reading the code and questions I have which may need changes or just responses.
Great quality PR here - especially the reuse of the soft delete work I added. 🦾
src/Microsoft.Health.Fhir.Core/Features/Operations/BulkDelete/BulkDeleteProcessingJob.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.Core/Features/Operations/BulkDelete/BulkDeleteOrchestratorJob.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.Core/Features/Operations/BulkDelete/Handlers/GetBulkDeleteHandler.cs
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.Core/Features/Operations/BulkDelete/BulkDeleteDefinition.cs
Outdated
Show resolved
Hide resolved
Another question about I really don't think it matters at all, but once this is GA we can't change it. Integer64 is a bit clearer since you cannot delete part of a resource. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job on this PR! 🦾 Approved pending build/tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦾🚀
Description
Adds audit logging to delete operations
Improves bulk delete performance
Related issues
Addresses User Story 104736: [Needs to be done prior to GA] Audit event logs need to be populated with delete information
Testing
FHIR Team Checklist
Semver Change (docs)
Patch