chore: change directory structure for components #3730

rimildeyjsr · 2020-08-15T12:05:37Z

Description

Motivation & context

Flatten the directory structure of fast components and fast-foundation elements:

change structure of /accordion/accordion-item -> /accordian and /accordian-item
change structure of /progress/progress and /progress/progress-ring -> /progress and /progress-ring
change structure of /tabs/tab and /tabs/tab-panel -> /tabs, /tab and /tab-panel

Fixes #3641

Issue type checklist

Chore: A change that does not impact distributed packages.
Bug fix: A change that fixes an issue, link to the issue above.
New feature: A change that adds functionality.

Is this a breaking change?

This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

I have added a new component
I have modified an existing component
I have updated the definition file
I have updated the configuration file

Process & policy checklist

I have added tests for my changes.
I have tested my changes.
I have updated the project documentation to reflect my changes.
I have read the CONTRIBUTING documentation and followed the standards for this project.

ghost · 2020-08-15T12:05:52Z

All CLA requirements met.

janechu · 2020-08-17T16:44:17Z

Looks like you need to update the pathing in the *.stories.ts files, you can try running storybook locally in fast-components and checking to make sure things are looking correct that way as well.

rimildeyjsr · 2020-08-17T18:52:31Z

@janechu thanks for the pointer! will do that 😄

rimildeyjsr · 2020-08-19T00:26:45Z

@janechu - Verified the changes on local, everything seems to be working fine now! I just can't get this lint_title build to succeed :(

nicholasrice · 2020-08-19T00:31:14Z

@rimildeyjsr Don't worry about lint_title ;) That fails for all PRs coming from a fork for unknown reasons.

rimildeyjsr · 2020-08-19T00:32:36Z

@nicholasrice ah ok! 😅

chrisdholt · 2020-08-19T19:15:27Z

packages/web-components/fast-components/src/tabs/index.ts

+export * from "../tab";
+export * from "../tab-panel";


I know these were previously being exported from this file, but now that we've gone to a flat structure, does this still make sense? I would expect that we might just export these from their own folders and export them directly from the root.

Makes sense, will make the changes

@rimildeyjsr it looks like this didn't fully get implemented from what I see but I think that's ok. I'm worried about this going too stale, so I've made an update here and if it passes the build I'll likely merge this and we can address this in a follow-up.

chrisdholt · 2020-08-19T19:15:51Z

packages/web-components/fast-foundation/src/progress/index.ts

+export * from "./progress.template";
+export * from "../progress-ring/index";


Same question here as with tabs:

I know these were previously being exported from this file, but now that we've gone to a flat structure, does this still make sense? I would expect that we might just export these from their own folders and export them directly from the root.

Makes sense, will make the edit!

chrisdholt · 2020-08-19T19:16:23Z

packages/web-components/fast-foundation/src/tabs/index.ts

+export * from "../tab/index";
+export * from "../tab-panel/index";


should these be exported from their own index file rather than this one now that we've gone to a flat structure?

They are being exported from their own index file, this was an unnecessary reference. Removing it

chrisdholt · 2020-08-19T19:16:43Z

packages/web-components/fast-foundation/src/accordion/index.ts

 export * from "./accordion.template";
 export * from "./accordion";
-export * from "./accordion-item";
+export * from "../accordion-item";


Should this be exported from it's own index file?

accordion item is being exported from its own index file, this export is not required. Removing.

rimildeyjsr · 2020-08-21T12:35:02Z

@chrisdholt - have made the changes as you suggested!

EisenbergEffect · 2020-08-25T20:00:07Z

@awentzel Can you take a look into what's happening with CI here? It's been running the unit test task for almost an hour. All this PR does is move files and fix up paths.

awentzel · 2020-08-26T14:28:31Z

I'm investigating the CI issue...

…ents and fast-foundation

awentzel · 2020-09-02T21:41:44Z

A GH Support Ticket has been filed to address this as I was unable to resolve. https://support.github.com/ticket/personal/0/821492

I'm hopeful that there are additional diagnostics from GH team to help resolve. As a possible workaround, I have considered merging without the testing successfully passing, then test after it's in master. However, I wanted to give GH a chance to respond first. This was marketed as high importance so hopefully, they come back soon.

chrisdholt · 2020-09-11T17:33:40Z

Pulling this down to test locally - I'd like to get this in so we don't get too out of sync and run into conflicts with changes to currently nested files.

chrisdholt · 2020-09-11T22:57:09Z

I think I have this fixed - I'm going to add and commit the changes.

packages/web-components/fast-foundation/src/tabs/index.ts

packages/web-components/fast-components/src/tabs/index.ts

chrisdholt · 2020-09-12T00:06:42Z

Thank you for the contribution @rimildeyjsr - and thanks for hanging with us while we debugged the build issue! 🎉

rimildeyjsr requested review from EisenbergEffect, chrisdholt, janechu and nicholasrice as code owners August 15, 2020 12:05

EisenbergEffect added this to the Release 08 milestone Aug 17, 2020

rimildeyjsr force-pushed the master branch 3 times, most recently from 7b74014 to 9150fb1 Compare August 19, 2020 00:09

rimildeyjsr changed the title ~~chore: flatten directory for accordian, progress, tabs in fast-compon…~~ chore: flatten directory for accordian, progress, tabs in fast-components and fast-foundation Aug 19, 2020

rimildeyjsr changed the title ~~chore: flatten directory for accordian, progress, tabs in fast-components and fast-foundation~~ chore: flatten directory structure for fast-components and fast-foundation Aug 19, 2020

rimildeyjsr changed the title ~~chore: flatten directory structure for fast-components and fast-foundation~~ chore: change directory structure for fast-components and fast-foundation Aug 19, 2020

rimildeyjsr changed the title ~~chore: change directory structure for fast-components and fast-foundation~~ chore: change directory structure for components Aug 19, 2020

nicholasrice approved these changes Aug 19, 2020

View reviewed changes

chrisdholt reviewed Aug 19, 2020

View reviewed changes

rimildeyjsr force-pushed the master branch from 6c50961 to 3a4396a Compare August 21, 2020 12:32

rimildeyjsr force-pushed the master branch 2 times, most recently from c1b32fb to a4bf41e Compare August 21, 2020 18:05

EisenbergEffect approved these changes Aug 25, 2020

View reviewed changes

awentzel force-pushed the master branch from 17e1ca6 to 9b00fb8 Compare August 26, 2020 14:45

EisenbergEffect mentioned this pull request Aug 26, 2020

chore(security): revert update to resolve security vulnerabilities (… #3787

Merged

12 tasks

awentzel force-pushed the master branch from 9b00fb8 to aa2ed14 Compare August 26, 2020 16:47

awentzel modified the milestones: Release 08, Release 10 Aug 26, 2020

rimildeyjsr and others added 2 commits September 2, 2020 12:31

chore: flatten directory for accordian, progress, tabs in fast-compon…

4b6bddd

…ents and fast-foundation

update to resolve yarn lock and apireport

375c17c

awentzel force-pushed the master branch from aa2ed14 to 375c17c Compare September 2, 2020 19:43

awentzel modified the milestones: Release 10, Release 12 Sep 2, 2020

Merge branch 'master' into master

84acfd1

awentzel closed this Sep 3, 2020

awentzel reopened this Sep 3, 2020

chrisdholt added 2 commits September 10, 2020 16:48

Merge branch 'master' into master

cba92b5

Merge branch 'master' into master

ed938f4

Merge branch 'master' into master

9e0a4fe

chrisdholt reviewed Sep 11, 2020

View reviewed changes

packages/web-components/fast-foundation/src/tabs/index.ts Show resolved Hide resolved

ensure we export tab panel

2086446

chrisdholt reviewed Sep 11, 2020

View reviewed changes

packages/web-components/fast-foundation/src/tabs/index.ts Outdated Show resolved Hide resolved

Update packages/web-components/fast-foundation/src/tabs/index.ts

06ac0e7

chrisdholt reviewed Sep 11, 2020

View reviewed changes

packages/web-components/fast-components/src/tabs/index.ts Show resolved Hide resolved

add tab-panel

366d43b

chrisdholt merged commit 6be7114 into microsoft:master Sep 11, 2020

		export * from "./progress.template";
		export * from "../progress-ring/index";

		export * from "../tab/index";
		export * from "../tab-panel/index";

chore: change directory structure for components #3730

chore: change directory structure for components #3730

Uh oh!

Conversation

rimildeyjsr commented Aug 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation & context

Issue type checklist

Process & policy checklist

Uh oh!

ghost commented Aug 15, 2020 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

janechu commented Aug 17, 2020

Uh oh!

rimildeyjsr commented Aug 17, 2020

Uh oh!

rimildeyjsr commented Aug 19, 2020

Uh oh!

nicholasrice commented Aug 19, 2020

Uh oh!

rimildeyjsr commented Aug 19, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rimildeyjsr commented Aug 21, 2020

Uh oh!

EisenbergEffect commented Aug 25, 2020

Uh oh!

awentzel commented Aug 26, 2020

Uh oh!

awentzel commented Sep 2, 2020

Uh oh!

chrisdholt commented Sep 11, 2020

Uh oh!

chrisdholt commented Sep 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chrisdholt commented Sep 12, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rimildeyjsr commented Aug 15, 2020 •

edited

Loading

ghost commented Aug 15, 2020 •

edited by ghost

Loading

chrisdholt commented Sep 11, 2020 •

edited

Loading