Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(security): revert update to resolve security vulnerabilities (… #3787

Merged
merged 6 commits into from
Sep 15, 2020

Conversation

awentzel
Copy link
Collaborator

#3769)"

This reverts commit a3e83d9.

Description

It appears this PR has broken master such that unit testing never completes and so reverting these changes to unstick pipeline.

Motivation & context

Unit testing on GH Actions is failing to complete after 6 hours the operation is canceled.

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@EisenbergEffect
Copy link
Contributor

EisenbergEffect commented Aug 26, 2020

What's strange about this is that other PR tests runs are completing. For example, this one #3784 which I created this morning is fine and so is this one #3786. It seems that the one that isn't completing is #3730

@awentzel
Copy link
Collaborator Author

awentzel commented Aug 26, 2020

What's strange about this is that other PR tests runs are completing. For example, this one #3784 which I created this morning is fine and so is this one #3786. It seems that the one that isn't completing is #3730

@EisenbergEffect these are completing on the PR itself pull_request event, but not when merging into master. This PR was the last PR to merge to master and since nothing has made it in master. Thus It feels like the culprit. This file also did include quite a few updates of the yarn.lock. Once this PR goes in, I will merge a PR that's ready into master to verify it's fixed again. Then I will reintroduce the security vulnerabilities is smaller focused bites to see if it's one particular package update that is causing it.

@awentzel awentzel changed the title Revert "chore(security): update to resolve security vulnerabilities (… chore(security): revert update to resolve security vulnerabilities (… Aug 26, 2020
@awentzel
Copy link
Collaborator Author

Looks like my theory was inaccurate as a PR just merged to Master. Please allow me to merge if appropriate as I continue to investigate.

@awentzel awentzel force-pushed the revert-3769-users/awentzel/sec-patches branch from 8744f2c to dc71a48 Compare September 15, 2020 21:53
@awentzel awentzel merged commit 63caad4 into master Sep 15, 2020
@awentzel awentzel deleted the revert-3769-users/awentzel/sec-patches branch September 15, 2020 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants