Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: removed warning caused in slider and prefixing attributes that may be false #2996

Merged
merged 2 commits into from
Apr 23, 2020
Merged

chore: removed warning caused in slider and prefixing attributes that may be false #2996

merged 2 commits into from
Apr 23, 2020

Conversation

marjonlynch
Copy link
Contributor

@marjonlynch marjonlynch commented Apr 23, 2020 •
edited
Loading

  • removed warning caused in slider
  • prefixing attributes, disabled and readonly that may be false
  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@marjonlynch marjonlynch self-assigned this Apr 23, 2020
@marjonlynch marjonlynch changed the title chore: removed warning caused in slider and prefixing attributes that may be false with ? chore: removed warning caused in slider and prefixing attributes that may be false Apr 23, 2020
@marjonlynch marjonlynch merged commit e5995dc into master Apr 23, 2020
@marjonlynch marjonlynch deleted the users/marjon/update-slider branch April 23, 2020 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdholt chrisdholt chrisdholt approved these changes

@EisenbergEffect EisenbergEffect EisenbergEffect approved these changes

@janechu janechu Awaiting requested review from janechu

@nicholasrice nicholasrice Awaiting requested review from nicholasrice

Assignees

@marjonlynch marjonlynch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marjonlynch @EisenbergEffect @chrisdholt