removed warning caused in slider and not showing attributes readonly …

…or disabled unless present (#2996)
microsoft · Apr 23, 2020 · e5995dc · e5995dc
1 parent 75a7ee2
commit e5995dc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/packages/web-components/fast-components/src/slider/slider.template.ts b/packages/web-components/fast-components/src/slider/slider.template.ts
@@ -9,8 +9,8 @@ export const SliderTemplate = html<Slider>`
         aria-valuenow="${x => x.value}"
         aria-valuemin="${x => x.min}"
         aria-valuemax="${x => x.max}"
-        aria-disabled="${x => x.disabled}"
-        aria-readonly="${x => x.readOnly}"
+        ?aria-disabled="${x => x.disabled}"
+        ?aria-readonly="${x => x.readOnly}"
         aria-orientation="${x => x.orientation}"
     >
         <div part="positioning-region" class="positioning-region">

diff --git a/packages/web-components/fast-components/src/slider/slider.ts b/packages/web-components/fast-components/src/slider/slider.ts
@@ -275,6 +275,7 @@ export class Slider extends FormAssociated<HTMLInputElement>
     /**
      * Handle a window mouse up during a drag operation
      */
+    /* eslint-disable-next-line @typescript-eslint/no-unused-vars */
     private handleWindowMouseUp = (event: MouseEvent): void => {
         this.stopDragging();
     };