Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hypertext component #210

Merged
merged 27 commits into from
Apr 13, 2018
Merged

feat: add hypertext component #210

Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
f063d64
rebased
Apr 5, 2018
a129d6a
renamed all to hypertext from hyperlink
Apr 2, 2018
0d262f5
renamed hyperlink to hypertext
Apr 2, 2018
209f428
microsoft appropriate test link used
Apr 2, 2018
ab94569
added hypertext references in react-msft and styles-msft
Apr 4, 2018
5037d28
added md file for hypertext
Apr 4, 2018
99731f6
missed hyperlink reference, and updated md doc to use hypertext
Apr 4, 2018
bdced4c
added more style to hypertext, fixed some possible build issues
Apr 4, 2018
c4da12a
chris helped added a couple good style things, fixed example text
Apr 5, 2018
ad63c30
addressing PR comments
Apr 5, 2018
5c4b7f3
changes to account for testing examples update
Apr 5, 2018
44ef96f
applied more PR comments
Apr 6, 2018
95f2f40
removed the text property on hypertext, will only use children
Apr 6, 2018
f274dfc
added newline to file so it builds?
Apr 6, 2018
c825fdd
updates to fix server build rules
Apr 6, 2018
3e0f94c
more tslint errors fixed
Apr 6, 2018
c5cfa5a
more tslint errors fixed
Apr 6, 2018
3f1e52d
updated snapshots
Apr 6, 2018
dad7b10
refactoring based on PR comments
Apr 6, 2018
451c9ad
merge issue resolved
Apr 6, 2018
148ba95
tslint stuff again
Apr 6, 2018
5b28c9d
PR comments applied
Apr 13, 2018
79d3549
rebased again
Apr 13, 2018
1c68f4d
PR comments applied
Apr 13, 2018
bd699e9
spacing on export fixed
Apr 13, 2018
4ca8ea6
added comments to handled props for hypertext
Apr 13, 2018
2159271
changes to accomodate contract interface update
Apr 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactoring based on PR comments
  • Loading branch information
marjonlynch committed Apr 13, 2018
commit dad7b10475b4eafd50863294ff4abadde932a984
4 changes: 3 additions & 1 deletion packages/fast-components-react-base/src/hypertext/hypertext.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,11 @@ import {IHypertextHandledProps, IHypertextManagedClasses, IHypertextUnhandledPro
import {IHypertextClassNameContract, IManagedClasses} from "@microsoft/fast-components-class-name-contracts";

/* tslint:disable-next-line */
class Hypertext extends Foundation<IHypertextHandledProps & IManagedClasses<IHypertextClassNameContract>, React.AllHTMLAttributes<HTMLAnchorElement>, {}> {
class Hypertext extends Foundation<IHypertextHandledProps & IManagedClasses<IHypertextClassNameContract>, React.AnchorHTMLAttributes<HTMLAnchorElement>, {}> {
protected handledProps: HandledProps<IHypertextHandledProps & IManagedClasses<IHypertextClassNameContract>> = {
managedClasses: void 0,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to enumerate any of the props here that are handled.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, done and done

href: void 0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really don't need to enumerate href as a prop either - it is included by the React.AnchorHTMLAttributes interface accurately for this component

children: void 0
};

/**
Expand Down