-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add hypertext component #210
Merged
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
f063d64
rebased
marjonlynch a129d6a
renamed all to hypertext from hyperlink
marjonlynch 0d262f5
renamed hyperlink to hypertext
marjonlynch 209f428
microsoft appropriate test link used
marjonlynch ab94569
added hypertext references in react-msft and styles-msft
marjonlynch 5037d28
added md file for hypertext
marjonlynch 99731f6
missed hyperlink reference, and updated md doc to use hypertext
marjonlynch bdced4c
added more style to hypertext, fixed some possible build issues
marjonlynch c4da12a
chris helped added a couple good style things, fixed example text
marjonlynch ad63c30
addressing PR comments
marjonlynch 5c4b7f3
changes to account for testing examples update
marjonlynch 44ef96f
applied more PR comments
marjonlynch 95f2f40
removed the text property on hypertext, will only use children
marjonlynch f274dfc
added newline to file so it builds?
marjonlynch c825fdd
updates to fix server build rules
marjonlynch 3e0f94c
more tslint errors fixed
marjonlynch c5cfa5a
more tslint errors fixed
marjonlynch 3f1e52d
updated snapshots
marjonlynch dad7b10
refactoring based on PR comments
marjonlynch 451c9ad
merge issue resolved
marjonlynch 148ba95
tslint stuff again
marjonlynch 5b28c9d
PR comments applied
marjonlynch 79d3549
rebased again
marjonlynch 1c68f4d
PR comments applied
marjonlynch bd699e9
spacing on export fixed
marjonlynch 4ca8ea6
added comments to handled props for hypertext
marjonlynch 2159271
changes to accomodate contract interface update
marjonlynch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
more tslint errors fixed
- Loading branch information
commit c5cfa5a5c15ce25314c4823034a0b564a89e293a
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,7 +23,7 @@ class Hypertext extends Foundation<IHypertextHandledProps & IManagedClasses<IHyp | |
{this.props.children} | ||
</a> | ||
); | ||
} | ||
} | ||
|
||
/** | ||
* Generates class names | ||
|
@@ -33,12 +33,12 @@ class Hypertext extends Foundation<IHypertextHandledProps & IManagedClasses<IHyp | |
} | ||
|
||
private generateAttributes(): {} { | ||
const attributes = {}; | ||
const attributes: any = {}; | ||
const HREF_INDEX: string = "href"; | ||
|
||
if (this.props.href) { | ||
attributes[HREF_INDEX] = this.props.href; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. does dot notation not work here? I know that you're likely getting an error, but if we can access via dot notation, let's do that instead. |
||
} | ||
} | ||
return attributes; | ||
} | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove this function. Because we're not manipulating this data, it can be safely applied with the
this.unhandledProps()
call.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1