fix: context menu styles to match new designs #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eljefe223
requested review from
nicholasrice,
janechu,
chrisdholt,
marjonlynch and
khamudom
chrisdholt
requested changes
Feb 1, 2019
packages/fast-components-styles-msft/src/context-menu-item/index.ts
Outdated
Show resolved
Hide resolved
nicholasrice
approved these changes
Feb 1, 2019
chrisdholt
approved these changes
Feb 2, 2019
eljefe223
force-pushed
the
users/jes/ContextMenuStyleFix
branch
2 times, most recently
from
9f1012d to
9045460
Compare
|
Code Climate has analyzed commit 9045460 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 85.4% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix context menu styles to match new designs
Motivation & context
Fix context menu styles to match new designs Design here:
https://www.figma.com/file/FnigSVQnGOXbEW8HQuEu1ZMo/UIS-Components?node-id=133%3A0
Issue type checklist
Is this a breaking change?
Process & policy checklist