Skip to content

Commit

Permalink
addressed PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
eljefe223 committed Feb 4, 2019
1 parent 95b5b76 commit 9045460
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import {
import { applyFocusVisible } from "@microsoft/fast-jss-utilities";
import { applyTypeRampConfig } from "../utilities/typography";
import typographyPattern from "../patterns/typography";
import { toPx } from "@microsoft/fast-jss-utilities";

const styles: ComponentStyles<ContextMenuItemClassNameContract, DesignSystem> = {
contextMenuItem: {
Expand All @@ -32,7 +33,11 @@ const styles: ComponentStyles<ContextMenuItemClassNameContract, DesignSystem> =
cursor: "default",
...applyTypeRampConfig("t7"),
background: backgroundColor,
borderRadius: "2px",
borderRadius: (config: DesignSystem): string => {
const designSystem: DesignSystem = withDesignSystemDefaults(config);

return toPx(designSystem.cornerRadius);
},
border: "2px solid transparent",
...applyFocusVisible({
borderColor: ensureForegroundNormal,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { ComponentStyles, ComponentStyleSheet } from "@microsoft/fast-jss-manage
import { ContextMenuClassNameContract } from "@microsoft/fast-components-class-name-contracts-base";
import { foregroundLarge } from "../utilities/colors";
import { elevation, ElevationMultiplier } from "../utilities/elevation";
import { toPx } from "@microsoft/fast-jss-utilities";

const styles: ComponentStyles<ContextMenuClassNameContract, DesignSystem> = (
config: DesignSystem
Expand All @@ -21,7 +22,7 @@ const styles: ComponentStyles<ContextMenuClassNameContract, DesignSystem> = (
padding: "4px 0",
maxWidth: "368px",
minWidth: "64px",
borderRadius: "4px",
borderRadius: toPx(designSystem.cornerRadius * 2),
},
};
};
Expand Down

0 comments on commit 9045460

Please sign in to comment.