Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace hardcoded version string + globs with build variables #213

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Replace hardcoded version string + globs with build variables #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb8a5b2
Remove usage of version glob in the .NET Isolated webjobs references …
cgillum Apr 4, 2024
8212dda
Update package version and CHANGELOG
cgillum Apr 4, 2024
ded8eb5
Update version check test
cgillum Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## v1.3.0 (Unreleased)

### Updates

* Replace hardcoded version string + globs with build variables ([#213](https://github.com/microsoft/durabletask-mssql/pull/213))

## v1.2.3

### Updates
Expand Down
12 changes: 11 additions & 1 deletion ...Extensions.DurableTask.SqlServer/Functions.Worker.Extensions.DurableTask.SqlServer.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<!-- Import common properties for all shipping packages-->
<Import Project="../common.props" />
Expand All @@ -20,4 +20,14 @@
<PackageReference Include="Microsoft.Azure.Functions.Worker.Extensions.Abstractions" Version="1.3.0" />
</ItemGroup>

<!-- This tells the .NET Isolated Worker SDK which WebJobs extension this package depends on -->
<ItemGroup>
<AssemblyAttribute Include="Microsoft.Azure.Functions.Worker.Extensions.Abstractions.ExtensionInformationAttribute">
<_Parameter1>Microsoft.DurableTask.SqlServer.AzureFunctions</_Parameter1>
<_Parameter2>$(PackageVersion)</_Parameter2>
<_Parameter3>true</_Parameter3>
<_Parameter3_IsLiteral>true</_Parameter3_IsLiteral>
</AssemblyAttribute>
</ItemGroup>

</Project>
7 changes: 0 additions & 7 deletions src/Functions.Worker.Extensions.DurableTask.SqlServer/Properties/AssemblyInfo.cs
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions src/common.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
<!-- Version settings: https://andrewlock.net/version-vs-versionsuffix-vs-packageversion-what-do-they-all-mean/ -->
<PropertyGroup>
<MajorVersion>1</MajorVersion>
<MinorVersion>2</MinorVersion>
<PatchVersion>3</PatchVersion>
<MinorVersion>3</MinorVersion>
<PatchVersion>0</PatchVersion>
<VersionPrefix>$(MajorVersion).$(MinorVersion).$(PatchVersion)</VersionPrefix>
<VersionSuffix></VersionSuffix>
<AssemblyVersion>$(MajorVersion).$(MinorVersion).0.0</AssemblyVersion>
Expand Down
4 changes: 2 additions & 2 deletions test/DurableTask.SqlServer.Tests/Integration/DatabaseManagement.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,8 +503,8 @@ async Task ValidateDatabaseSchemaAsync(TestDatabase database, string schemaName
database.ConnectionString,
schemaName);
Assert.Equal(1, currentSchemaVersion.Major);
Assert.Equal(2, currentSchemaVersion.Minor);
Assert.Equal(3, currentSchemaVersion.Patch);
Assert.Equal(3, currentSchemaVersion.Minor);
Assert.Equal(0, currentSchemaVersion.Patch);
}

sealed class TestDatabase : IDisposable
Expand Down
Loading