Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace hardcoded version string + globs with build variables #213

Merged
merged 3 commits into from
Apr 5, 2024

Conversation

cgillum
Copy link
Member

@cgillum cgillum commented Apr 4, 2024

Resolves #212

This PR does two things:

Note that we're including this pas part of a 1.3.x release since only 1.2.x versions are affected by the version glob issue.

…and make the version configuration use build variables instead of hardcoding.
@cgillum cgillum requested review from jviau and bachuv April 4, 2024 18:08
@cgillum cgillum merged commit d6e0361 into main Apr 5, 2024
2 checks passed
@cgillum cgillum deleted the cgillum/fix212 branch April 5, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants