Skip to content

fix objectDisposed exception in RefreshTokenAsync() #5037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2018
Merged

fix objectDisposed exception in RefreshTokenAsync() #5037

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions CSharp/Library/Microsoft.Bot.Connector.Shared/MicrosoftAppCredentials.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,16 +310,16 @@ private OAuthException(SerializationInfo info, StreamingContext context)
/// <returns></returns>
private async Task<OAuthResponse> RefreshTokenAsync()
{
var content = new FormUrlEncodedContent(new Dictionary<string, string>()
while (true)
{
var content = new FormUrlEncodedContent(new Dictionary<string, string>()
{
{ "grant_type", "client_credentials" },
{ "client_id", MicrosoftAppId },
{ "client_secret", MicrosoftAppPassword },
{ "scope", OAuthScope }
});

while (true)
{
using (var response = await g_httpClient.PostAsync(OAuthEndpoint, content).ConfigureAwait(false))
{
string body = null;
Expand All @@ -336,13 +336,13 @@ private async Task<OAuthResponse> RefreshTokenAsync()
#if NET45
System.Diagnostics.Trace.TraceError(body ?? response.ReasonPhrase);
#else
logger?.LogWarning($"RefreshTokenAsync() Exception) {body ?? response.ReasonPhrase}");
logger?.LogWarning($"RefreshTokenAsync() Exception {body ?? response.ReasonPhrase}");
#endif

}

// try again in a bit to prevent hammering a service if it's not working
await Task.Delay((int)TimeSpan.FromSeconds(1).TotalMilliseconds);
await Task.Delay(TimeSpan.FromSeconds(30));
Copy link
Member

@EricDahlvang EricDahlvang Sep 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

30 seconds? Is this change intentional? (that's a long time)

}
}
}
Expand Down