fix objectDisposed exception in RefreshTokenAsync() #5037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricDahlvang
reviewed
Sep 5, 2018
|
|
||
| // try again in a bit to prevent hammering a service if it's not working | ||
| await Task.Delay((int)TimeSpan.FromSeconds(1).TotalMilliseconds); | ||
| await Task.Delay(TimeSpan.FromSeconds(30)); |
There was a problem hiding this comment.
30 seconds? Is this change intentional? (that's a long time)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HttpResponseMessage implements IDispose, which internally calls .Dispose() on the HttpContent passed into PostAsync(), invalidating the content that was attempted to be reusued in another request.
This fix creates a new Content to be submitted on every attempt by moving the FormUrlEncodedContent inside the retry loop