This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Sibling $ref required removed from definition.#944
Merged
Conversation
munozemilio
reviewed
Aug 18, 2020
| ], | ||
| "internalConsoleOptions": "openOnSessionStart", | ||
| "cwd": "${workspaceFolder}/packages/dialog/test/commands/dialog" | ||
| "cwd": "${workspaceFolder}/../botbuilder-dotnet/" |
Contributor
There was a problem hiding this comment.
this may not work for others
munozemilio
approved these changes
Aug 18, 2020
added 2 commits
August 18, 2020 12:01
Codecov Report
@@ Coverage Diff @@
## master #944 +/- ##
==========================================
- Coverage 72.48% 68.73% -3.76%
==========================================
Files 175 174 -1
Lines 11097 9415 -1682
Branches 968 879 -89
==========================================
- Hits 8044 6471 -1573
+ Misses 2706 2617 -89
+ Partials 347 327 -20
Continue to review full report at Codecov.
|
munozemilio
pushed a commit
that referenced
this pull request
Aug 19, 2020
* Sibling $ref required removed from definition. * Update readme.
munozemilio
added a commit
that referenced
this pull request
Aug 19, 2020
* Change dialog:merge bundling (#932) * Working bundle. * Figuring out $bundled for $ref * Remove $bundled. * Add tests for more complex schema. * Single process schema: Co-authored-by: Emilio Munoz <emmunozp@microsoft.com> * Sibling $ref required removed from definition. (#944) * Sibling $ref required removed from definition. * Update readme. Co-authored-by: Chris McConnell <chrimc@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new bundler exposed an issue in our component schema. When using Activity there would be a $ref sibling required. This conflicted with the required in Activity. This is supported in JSON Schema 8, but fixed this for now by removing the definition required. This makes schema more readable and may be needed for Composer release.