This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Conversation
munozemilio
reviewed
Aug 12, 2020
Codecov Report
@@ Coverage Diff @@
## master #932 +/- ##
==========================================
+ Coverage 57.53% 67.16% +9.63%
==========================================
Files 220 175 -45
Lines 17118 8618 -8500
Branches 2404 848 -1556
==========================================
- Hits 9848 5788 -4060
+ Misses 6686 2521 -4165
+ Partials 584 309 -275
Continue to review full report at Codecov.
|
munozemilio
approved these changes
Aug 12, 2020
cleemullins
approved these changes
Aug 12, 2020
Contributor
|
@munozemilio Please merge when ready. Do we need to cherrypick to R10? |
added 2 commits
August 12, 2020 13:49
munozemilio
added a commit
that referenced
this pull request
Aug 19, 2020
* Working bundle. * Figuring out $bundled for $ref * Remove $bundled. * Add tests for more complex schema. * Single process schema: Co-authored-by: Emilio Munoz <emmunozp@microsoft.com>
munozemilio
added a commit
that referenced
this pull request
Aug 19, 2020
* Change dialog:merge bundling (#932) * Working bundle. * Figuring out $bundled for $ref * Remove $bundled. * Add tests for more complex schema. * Single process schema: Co-authored-by: Emilio Munoz <emmunozp@microsoft.com> * Sibling $ref required removed from definition. (#944) * Sibling $ref required removed from definition. * Update readme. Co-authored-by: Chris McConnell <chrimc@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement bundling so that it keeps the relationship to the original source of external schema. This makes schemas easier to understand and simplifies how Composer deals with schema.