This repository was archived by the owner on Jan 15, 2025. It is now read-only.
cross train and lu/qna build optimization for composer#889
Merged
Conversation
…sTrainOptimization
This was referenced Jul 13, 2020
Closed
Codecov Report
@@ Coverage Diff @@
## master #889 +/- ##
==========================================
- Coverage 60.45% 57.53% -2.93%
==========================================
Files 220 219 -1
Lines 17887 16503 -1384
Branches 2316 2265 -51
==========================================
- Hits 10814 9495 -1319
+ Misses 6494 6428 -66
- Partials 579 580 +1
Continue to review full report at Codecov.
|
Contributor
|
@alanlong9278 @luhan2017 can you help verify this feature is as what we expected at composer side |
This was referenced Jul 22, 2020
munozemilio
approved these changes
Jul 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #883, #880, #879, #878 and microsoft/botbuilder-dotnet#4144. All these issues are related with composer crosstrain and lu/qna:build scenarios. This PR is to resolve these issues including:
Now composer only need to call below flow directly and DO NOT need any other tricy calling logic:
call crosstrain() -> lubuild.loadContents() ->lubuild.build() -> lubuild.writeDialogAssets() -> qnabuild.loadContents() -> qnabuild.build() -> qnabuild.writeDialogAssets()