Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Move CrossTrainRecognizer generation logic from lubuild/qnabuild to crosstrain  #880

@luhan2017

Description

@luhan2017

we hit some issue when enable qna and crosstrain recognizer in composer. So I propose to have a more clear design of the functionality of each lib. We should not put the crosstrain recognizer logic in qnabuild or lubuild, what if non-composer users and they don't care about crosstrain? I think crosstrain recognizer genration logic should be in crosstrain library.

The whole crosstrain + lubuild + qnabuild process should look like this.

  1. composer will call crosstrain api.
    Here is the crosstrain logic.
    if .lu and .qna are both empty. do nothing, and just generate a CrossTrainedRecognizer with no recognizers inside.
    if only .lu not empty. crosstrain on lu only, and generate a crosstrainedrecognizer with lu recognizer only.
    if only .qna not empty. no need crosstrain, and generate a crosstrainedrecognzier with qna recognizer only.
    if both not empty, crosstrain them, and generate a crosstrained recognizer with both lu and qna.

lubuild don't care qna, qnabuild don't care lu.
they just take the .lu files or .qna files if files are not empty, prompt for keys and generate the multilanuage luis/qna recognizer.

@vishwacsena, @boydc2014 thoughts?

Metadata

Metadata

Assignees

Labels

P1Painful if we don't fix, won't block releasingR10Release 10 - August 17th, 2020lunon luis api commandstriagedReviewed by the Triage Team, not approved

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions