Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Comments

Removing SDK from LUIS endpoint calls#877

Merged
munozemilio merged 8 commits intomasterfrom
emimunoz/remove-luis-sdk
Jul 10, 2020
Merged

Removing SDK from LUIS endpoint calls#877
munozemilio merged 8 commits intomasterfrom
emimunoz/remove-luis-sdk

Conversation

@munozemilio
Copy link
Contributor

@munozemilio munozemilio commented Jul 8, 2020

Fixes #829, #834, #838

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2020

Codecov Report

Merging #877 into master will increase coverage by 0.93%.
The diff coverage is 92.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #877      +/-   ##
==========================================
+ Coverage   56.81%   57.75%   +0.93%     
==========================================
  Files         214      217       +3     
  Lines       14555    15226     +671     
  Branches     2036     2051      +15     
==========================================
+ Hits         8270     8794     +524     
- Misses       5757     5893     +136     
- Partials      528      539      +11     
Impacted Files Coverage Δ
...rc/commands/luis/application/assignazureaccount.ts 100.00% <ø> (ø)
...kages/luis/src/commands/luis/application/create.ts 84.21% <ø> (+3.25%) ⬆️
...kages/luis/src/commands/luis/application/delete.ts 71.42% <ø> (-9.83%) ⬇️
...ages/luis/src/commands/luis/application/publish.ts 100.00% <ø> (ø)
...ckages/luis/src/commands/luis/application/query.ts 100.00% <ø> (+12.50%) ⬆️
...kages/luis/src/commands/luis/application/rename.ts 100.00% <ø> (ø)
packages/luis/src/commands/luis/version/delete.ts 100.00% <ø> (ø)
packages/luis/src/commands/luis/version/rename.ts 100.00% <ø> (ø)
packages/luis/src/utils/index.ts 77.04% <ø> (-2.64%) ⬇️
packages/luis/src/commands/luis/train/run.ts 68.75% <75.00%> (+14.20%) ⬆️
... and 99 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a034fe...066c464. Read the comment docs.

@munozemilio munozemilio marked this pull request as ready for review July 9, 2020 23:15
@munozemilio
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@microsoft microsoft deleted a comment from azure-pipelines bot Jul 9, 2020
@munozemilio munozemilio merged commit 3be1143 into master Jul 10, 2020
@munozemilio munozemilio deleted the emimunoz/remove-luis-sdk branch July 10, 2020 23:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants