This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Merged
Conversation
Contributor
|
@munozemilio please help to cherry-pick the changes in luis build to your PR since luis build is also using export api. I think it also needs the fix. Here is the commit 8457feb |
Codecov Report
@@ Coverage Diff @@
## master #829 +/- ##
==========================================
- Coverage 57.16% 57.10% -0.07%
==========================================
Files 214 213 -1
Lines 14912 14748 -164
Branches 2076 2046 -30
==========================================
- Hits 8525 8422 -103
+ Misses 5826 5789 -37
+ Partials 561 537 -24
Continue to review full report at Codecov.
|
mdrichardson
approved these changes
Jul 2, 2020
| try { | ||
| const appJSON = await client.versions.exportMethod(appId, versionId) | ||
| if (!appJSON) throw new CLIError('Failed to export file') | ||
| let url = endpoint + '/luis/authoring/v3.0-preview/apps/' + appId + '/versions/' + versionId + '/export?format=json' |
Contributor
There was a problem hiding this comment.
Should we make these URLs a constant? Might make future changes easier, especially once the preview part is removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #818
This will export the json in the expected format