This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Merged
Conversation
Contributor
|
@feich-ms can we also update this so we do not write out |
Contributor
Author
|
@vishwacsena, actually I already did this in pr #804 when first updating Luis build. will move from that pr to this one for better review |
vishwacsena
added
lu
munozemilio
approved these changes
May 26, 2020
munozemilio
added a commit
that referenced
this pull request
May 26, 2020
* write out endpointKeys to console for qnamaker build * qnamaker:build do not write .dialog if no --out is specified * fix typo Co-authored-by: Emilio Munoz <emmunozp@microsoft.com>
munozemilio
added a commit
that referenced
this pull request
May 27, 2020
* Update dialog:merge tests around projects (#784) * Updating tests. * Merge branch '4.9' into chrimc/test Add nuget semver. * Change test to avoid checking path parts. * Follow package.json dependencies. * Fix merge match. * fix (#792) Co-authored-by: Vishwac Sena Kannan <vishwacsenakannan@MININT-GO8OQNV.redmond.corp.microsoft.com> * Fix to remove validation. (#793) Co-authored-by: Vishwac Sena Kannan <vishwacsenakannan@Vishwacs-MBP.guest.corp.microsoft.com> * fix the priority of stdin and in (#796) * fix the priority of stdin and in * fix the same issue in bf luis:generate * repalce all priority between stdin and --in * fix logic * remove only in luis build tests * Fix for direct luis direct version publish (#798) * Remove LUIS sdk and replace with direct http request * Removing unused line of code * fix (#802) Co-authored-by: Vishwac Sena Kannan <vishwacsenakannan@MININT-GO8OQNV.redmond.corp.microsoft.com> * fix (#803) Co-authored-by: Vishwac Sena Kannan <vishwacsenakannan@MININT-GO8OQNV.redmond.corp.microsoft.com> Co-authored-by: Emilio Munoz <emmunozp@microsoft.com> * Various fixes to bf-lu (#813) * various fixes. * fixes * updates * updates * fix for luis:build issue. * updates for nDepth reference resolver. * Update luis:build to create result using luis() Co-authored-by: Vishwac Sena Kannan <vishwacsenakannan@MININT-GO8OQNV.redmond.corp.microsoft.com> Co-authored-by: Vishwac Sena Kannan <vishwacsenakannan@Vishwacs-MBP.guest.corp.microsoft.com> Co-authored-by: Vishwac Sena Kannan <vishwacsenakannan@za-lyshange1811.africa.corp.microsoft.com> * Set build version * resolve qnamaker build issues (#812) * write out endpointKeys to console for qnamaker build * qnamaker:build do not write .dialog if no --out is specified * fix typo Co-authored-by: Emilio Munoz <emmunozp@microsoft.com> * resolve luis build issues (#804) * luis build do not write dialogs if no --out specified * qnamaker:build do not write .dialog if no --out is specified * fix suffix issue in luis build * revert qnamaker changes in this PR and add to another * fix typo Co-authored-by: Emilio Munoz <emmunozp@microsoft.com> * Adding missing code lost in merges * Fixing merge * Adding missing test files * Fixing readme files Co-authored-by: Chris McConnell <chrimc@microsoft.com> Co-authored-by: Vishwac Sena Kannan <vishwack@hotmail.com> Co-authored-by: Vishwac Sena Kannan <vishwacsenakannan@MININT-GO8OQNV.redmond.corp.microsoft.com> Co-authored-by: Vishwac Sena Kannan <vishwacsenakannan@Vishwacs-MBP.guest.corp.microsoft.com> Co-authored-by: Fei Chen <43032123+feich-ms@users.noreply.github.com> Co-authored-by: Vishwac Sena Kannan <vishwacsenakannan@za-lyshange1811.africa.corp.microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve qnamaker build related issues in #800
Qnamaker:build do not write .dialog if no –out is specified.
Resolved: fixed in PR
There is no way to get endpoint key. We should print this on screen. Note the endpoint key is different from authoring key and I believe is per KB – need to verify and resolve.
Resolved: fixed in this PR
Fix issue with config relative path. Relative path must always be relative to the CWD()
Resolved: --qnaConfig is not supported yet. We have a feature request here bf qnamaker:build should support --qnaconfig #751. Will make it relative to CWD() in that implementation.