Update BF-LU to update validation for entity references in patterns#803
Update BF-LU to update validation for entity references in patterns#803
Conversation
|
|
||
| const updateEntityParentTreeWithAllEntityTypes = function(finalLUISJSON, entityParentTree) | ||
| { | ||
| (finalLUISJSON.prebuiltEntities || []).forEach(entity => addEntityToParentTree(entityParentTree, entity.name)); |
There was a problem hiding this comment.
The same operation is done for all properties. This could be replaced by a for going over an array
munozemilio
left a comment
There was a problem hiding this comment.
Small code improvement proposed
|
@vishwac could you please add details on the fix priority and issue |
|
@munozemilio sure. LUIS recently relaxed the requirement around uniqueness of entity names. Prior to build, all entity names across their scope (including child entities) need to be unique across the entire application. With recent changes to LUIS, entity names need to be unique under the immediate parent scope. This means I can have a global entity Without this fix, BF-LU parser will disallow child entities with same name as a different globally scoped entity. e.g. |
* Update dialog:merge tests around projects (#784) * Updating tests. * Merge branch '4.9' into chrimc/test Add nuget semver. * Change test to avoid checking path parts. * Follow package.json dependencies. * Fix merge match. * fix (#792) Co-authored-by: Vishwac Sena Kannan <vishwacsenakannan@MININT-GO8OQNV.redmond.corp.microsoft.com> * Fix to remove validation. (#793) Co-authored-by: Vishwac Sena Kannan <vishwacsenakannan@Vishwacs-MBP.guest.corp.microsoft.com> * fix the priority of stdin and in (#796) * fix the priority of stdin and in * fix the same issue in bf luis:generate * repalce all priority between stdin and --in * fix logic * remove only in luis build tests * Fix for direct luis direct version publish (#798) * Remove LUIS sdk and replace with direct http request * Removing unused line of code * fix (#802) Co-authored-by: Vishwac Sena Kannan <vishwacsenakannan@MININT-GO8OQNV.redmond.corp.microsoft.com> * fix (#803) Co-authored-by: Vishwac Sena Kannan <vishwacsenakannan@MININT-GO8OQNV.redmond.corp.microsoft.com> Co-authored-by: Emilio Munoz <emmunozp@microsoft.com> * Various fixes to bf-lu (#813) * various fixes. * fixes * updates * updates * fix for luis:build issue. * updates for nDepth reference resolver. * Update luis:build to create result using luis() Co-authored-by: Vishwac Sena Kannan <vishwacsenakannan@MININT-GO8OQNV.redmond.corp.microsoft.com> Co-authored-by: Vishwac Sena Kannan <vishwacsenakannan@Vishwacs-MBP.guest.corp.microsoft.com> Co-authored-by: Vishwac Sena Kannan <vishwacsenakannan@za-lyshange1811.africa.corp.microsoft.com> * Set build version * resolve qnamaker build issues (#812) * write out endpointKeys to console for qnamaker build * qnamaker:build do not write .dialog if no --out is specified * fix typo Co-authored-by: Emilio Munoz <emmunozp@microsoft.com> * resolve luis build issues (#804) * luis build do not write dialogs if no --out specified * qnamaker:build do not write .dialog if no --out is specified * fix suffix issue in luis build * revert qnamaker changes in this PR and add to another * fix typo Co-authored-by: Emilio Munoz <emmunozp@microsoft.com> * Adding missing code lost in merges * Fixing merge * Adding missing test files * Fixing readme files Co-authored-by: Chris McConnell <chrimc@microsoft.com> Co-authored-by: Vishwac Sena Kannan <vishwack@hotmail.com> Co-authored-by: Vishwac Sena Kannan <vishwacsenakannan@MININT-GO8OQNV.redmond.corp.microsoft.com> Co-authored-by: Vishwac Sena Kannan <vishwacsenakannan@Vishwacs-MBP.guest.corp.microsoft.com> Co-authored-by: Fei Chen <43032123+feich-ms@users.noreply.github.com> Co-authored-by: Vishwac Sena Kannan <vishwacsenakannan@za-lyshange1811.africa.corp.microsoft.com>
Fixing an issue that @chrimc62 found via generated dialogs.