Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Comments

[R10] fix issues #770 and #778#785

Merged
feich-ms merged 11 commits intomasterfrom
feich/Optimizations
May 19, 2020
Merged

[R10] fix issues #770 and #778#785
feich-ms merged 11 commits intomasterfrom
feich/Optimizations

Conversation

@feich-ms
Copy link
Contributor

fix issue #770 and issue #778.

@feich-ms feich-ms requested a review from munozemilio as a code owner May 13, 2020 08:49
@feich-ms feich-ms requested review from boydc2014 and vishwacsena May 14, 2020 08:23
@vishwacsena
Copy link
Contributor

@feich-ms can we add tests?

@feich-ms
Copy link
Contributor Author

@vishwacsena, unit tests for locale issue are added but the endpoint feature cannot be tested by unit tests as it needs to be with config:set:luis command. I did manual tests in package/cli/bin folder with below cmd

  1. run config:set:luis --endpoint https://chinaeast2.api.cognitive.azure.cn
  2. run luis:build --in a.zh-cn.lu --authoringKey xxx --out . --suffix feich --botName test --region chinaeast2 --fallbackLocale zh-cn

And it works well when I'm using the authoringKey from https://luis.azure.cn/

@feich-ms feich-ms merged commit 71aaf0d into master May 19, 2020
@feich-ms feich-ms deleted the feich/Optimizations branch May 19, 2020 05:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants