Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

luis:build parse lu file with incorrect locale priority #770

@feich-ms

Description

@feich-ms

Versions

What CLI version are you using.
What Nodejs version are you using
What command-line interpreters are you using
What OS are you using

Describe the bug

When users use luis:build to publish lu files, the locale of that lu file will be specified under such priority
Culture from file name(a.en-us.lu) > Culture from lu file setting(@> !# @app.culture = en-us) > default culture(default to en-us if not specified by users).

However, in current implementation, the culture passed to build function in luisCollate is default culture instead of culture from file name. This will introduce parser errors when default culture is set to other unreasonable values.

To Reproduce

Steps to reproduce the behavior:

  1. use luis:build to publish a lu file with below definitions but set defaultCulture to it-it
    @ prebuilt personName
  2. You will see some warings and errors like below
[WARN]: Requested PREBUILT entity "personName is not available for the requested locale: it-it
  Skipping this prebuilt entity..
The model name { personName } are reserved.

Expected behavior

Give a clear and concise description of what you expected to happen.

Screenshots

If applicable, add screenshots to help explain your problem.
image

Additional context

Add any other context about the problem here.

[bug]

Metadata

Metadata

Assignees

Labels

R10Release 10 - August 17th, 2020bugIndicates an unexpected problem or an unintended behavior.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions