Skills: Cancel dialogs only if EOC is coming from parent. #860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelsrz
requested changes
Mar 12, 2020
| def __is_eoc_coming_from_parent(turn_context: TurnContext) -> bool: | ||
| # To determine the direction we check callerId property which is set to the parent bot | ||
| # by the BotFrameworkHttpClient on outgoing requests. | ||
| return not turn_context.activity.caller_id |
Member
There was a problem hiding this comment.
I believe the return value should be:
return bool(turn_context.activity.caller_id)
gabog
suggested changes
Mar 12, 2020
Contributor
gabog
left a comment
gabog
left a comment
There was a problem hiding this comment.
Is the change to set the caller ID in a different PR?
microsoft/botbuilder-dotnet@3730963#diff-51b4b90671d9033d3ef08fa3aadb2feb
gabog
approved these changes
Mar 12, 2020
axelsrz
approved these changes
Mar 12, 2020
axelsrz
added a commit
that referenced
this pull request
Mar 12, 2020
* Skills: Cancel dialogs only if EOC is coming from parent. * Updating __is_eoc_coming_from_parent condition * modify activity.caller_id in bfhttpclient Co-authored-by: Axel Suárez <axsuarez@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #859