Skip to content

[PORT] EoC should only be handled when coming from parent in RunAsync #859

@tomlm

Description

@tomlm

Port this change from botbuilder-dotnet/master branch:
microsoft/botbuilder-dotnet#3540

Fixes #3541

Added check to only cancel dialogs in RunAsync when EoC comes from a parent bot (root or skill).

The issue was that this affected part of the code was being triggered when a skill responds with an EoC to a caller (EoCs are routed back to the pipeline in SkillHandler).

This PR also applies the urn format to CallerId as per OBI Spec

Changed projects

  • Microsoft.Bot.Builder.Dialogs
  • integration

Metadata

Metadata

Assignees

Labels

P0Must Fix. Release-blockerR8Release 8 - March 16th, 2020

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions