This repository was archived by the owner on Jan 5, 2026. It is now read-only.
[QnA Maker] Multi-turn support for python #305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@trojenguri its build is failing on linting issues Please pip install
so that it'll auto-format your code to the repo's rules and also give you the linting errors that'll need to be fixed for the build to pass:
|
Zerryth
previously requested changes
Aug 21, 2019
libraries/botbuilder-ai/botbuilder/ai/qna/models/qna_request_context.py
Outdated
Show resolved
Hide resolved
libraries/botbuilder-ai/botbuilder/ai/qna/models/qna_request_context.py
Outdated
Show resolved
Hide resolved
axelsrz
approved these changes
Aug 26, 2019
Member
axelsrz
left a comment
axelsrz
left a comment
There was a problem hiding this comment.
Hello @trojenguri nice PR! I would like to merge this whenever @cleemullins takes the C# and JS ones.
cleemullins
approved these changes
Aug 27, 2019
libraries/botbuilder-ai/botbuilder/ai/qna/models/generate_answer_request_body.py
Show resolved
Hide resolved
libraries/botbuilder-ai/botbuilder/ai/qna/models/generate_answer_request_body.py
Outdated
Show resolved
Hide resolved
cleemullins
previously requested changes
Aug 27, 2019
Contributor
cleemullins
left a comment
cleemullins
left a comment
There was a problem hiding this comment.
Please increase code coverage metrics.
axelsrz
suggested changes
Aug 28, 2019
libraries/botbuilder-ai/botbuilder/ai/qna/models/generate_answer_request_body.py
Outdated
Show resolved
Hide resolved
libraries/botbuilder-ai/botbuilder/ai/qna/models/qnamaker_trace_info.py
Outdated
Show resolved
Hide resolved
libraries/botbuilder-ai/botbuilder/ai/qna/models/generate_answer_request_body.py
Show resolved
Hide resolved
axelsrz
approved these changes
Aug 29, 2019
axelsrz
dismissed stale reviews from Zerryth and cleemullins
changes addressed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-turn support for python