[QnA Maker] Support for multiturn is added #2397

gurvsing · 2019-08-12T12:18:27Z

Support for multiturn is added

fuselabs · 2019-08-12T12:29:49Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

libraries/Microsoft.Bot.Builder.AI.QnA/Models/Prompt.cs

cleemullins

cleemullins

Code here is good.

Please link the JS and Python implementations, then we can merge.

gurvsing · 2019-08-14T12:24:42Z

Code here is good.

Please link the JS and Python implementations, then we can merge.

NodeJS PR: microsoft/botbuilder-js#1110

fuselabs · 2019-08-14T12:29:58Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

coveralls · 2019-08-16T07:25:26Z

Pull Request Test Coverage Report for Build 77021

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.9%) to 80.341%

Totals
Change from base Build 76933:	1.9%
Covered Lines:	3396
Relevant Lines:	4227

💛 - Coveralls

fuselabs · 2019-08-16T07:28:19Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

gurvsing · 2019-08-27T07:49:10Z

Python PR: microsoft/botbuilder-python#305

cleemullins

The code in the PR looks fine. However, you've dropped overall code coverage by 2%.

Overall coverage decreased (-1.8%) to 78.606%

Please write (simple) tests for all your new code.

libraries/Microsoft.Bot.Builder.AI.QnA/Models/Prompt.cs

libraries/Microsoft.Bot.Builder.AI.QnA/Models/QnARequestContext.cs

libraries/Microsoft.Bot.Builder.AI.QnA/Utils/GenerateAnswerUtils.cs

cleemullins · 2019-08-27T17:25:51Z

Please improve the overall test covereage. This code drops our overall score by 2%.

fuselabs · 2019-08-28T12:27:33Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

…builder-dotnet into gurvsing/multiturn

fuselabs · 2019-08-28T12:45:07Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

gurvsing · 2019-08-28T13:01:52Z

Please improve the overall test covereage. This code drops our overall score by 2%.

It was due to changes in master which was not merged. Now it got increased.

Support for multiturn is added

c180f26

gurvsing requested a review from cleemullins August 13, 2019 14:24

cleemullins reviewed Aug 13, 2019

View reviewed changes

libraries/Microsoft.Bot.Builder.AI.QnA/Models/Prompt.cs Outdated Show resolved Hide resolved

cleemullins approved these changes Aug 13, 2019

View reviewed changes

cleemullins added parity with JS labels Aug 13, 2019

cleemullins suggested changes Aug 13, 2019

View reviewed changes

Updating tests

5eb016f

Comment fix

9412c7c

gurvsing requested a review from cleemullins August 16, 2019 11:57

cleemullins approved these changes Aug 27, 2019

View reviewed changes

cleemullins suggested changes Aug 27, 2019

View reviewed changes

Zerryth mentioned this pull request Aug 27, 2019

QnA Maker follow-up prompts do not work in test WebChat microsoft/botbuilder-tools#1272

Closed

gurvsing added 5 commits August 28, 2019 17:30

Support for multiturn is added

ef8e36f

Updating tests

1c6c993

Comment fix

4bcdd25

Comment addressed

70eb14c

Merge changes

66444f9

gurvsing added 3 commits August 28, 2019 18:03

Comment addressed

8c0f6fc

Merge branch 'master' into gurvsing/multiturn

e89ef24

Merge branch 'gurvsing/multiturn' of https://github.com/microsoft/bot…

8544fa7

…builder-dotnet into gurvsing/multiturn

gurvsing requested a review from cleemullins August 28, 2019 13:05

cleemullins approved these changes Aug 28, 2019

View reviewed changes

cleemullins merged commit 71c2b9b into master Aug 28, 2019

cleemullins deleted the gurvsing/multiturn branch August 28, 2019 17:33

hansmbakker mentioned this pull request Sep 2, 2019

QnA maker multi-turn response #1906 #1930

Closed

[QnA Maker] Support for multiturn is added #2397

[QnA Maker] Support for multiturn is added #2397

Uh oh!

Conversation

gurvsing commented Aug 12, 2019

Uh oh!

fuselabs commented Aug 12, 2019

Uh oh!

Uh oh!

cleemullins left a comment

Choose a reason for hiding this comment

Uh oh!

cleemullins left a comment

Choose a reason for hiding this comment

Uh oh!

gurvsing commented Aug 14, 2019

Uh oh!

fuselabs commented Aug 14, 2019

Uh oh!

coveralls commented Aug 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 77021

💛 - Coveralls

Uh oh!

fuselabs commented Aug 16, 2019

Uh oh!

gurvsing commented Aug 27, 2019

Uh oh!

cleemullins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cleemullins commented Aug 27, 2019

Uh oh!

fuselabs commented Aug 28, 2019

Uh oh!

fuselabs commented Aug 28, 2019

Uh oh!

gurvsing commented Aug 28, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

coveralls commented Aug 16, 2019 •

edited

Loading