Refactored SkillDialog to call ConversationFacotry.CreateConversationId only once #1326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

tracyboehrer merged 1 commit into master from trboehre/skillconversationid

Aug 7, 2020

Member

tracyboehrer commented Aug 6, 2020

Fixes #1322


          Refactored SkillDialog to call ConversationFacotry.CreateConversation…

a251259

…Id only once

tracyboehrer requested a review from axelsrz

August 6, 2020 14:19

axelsrz approved these changes

View reviewed changes

libraries/botbuilder-dialogs/tests/test_skill_dialog.py

@@ @@ -148,10 +148,13 @@ async def capture( @@
                           conversation_state=conversation_state,
                       )
+                      assert len(dialog_options.conversation_id_factory.conversation_refs) == 0

Member

axelsrz Aug 7, 2020

this is nitpicking but this could be changed to
assert not dialog_options.conversation_id_factory.conversation_refs

tracyboehrer merged commit 0847fd5 into master

tracyboehrer deleted the trboehre/skillconversationid branch

August 7, 2020 17:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet