Skip to content

[PORT] Refactored SkillDialog to call ConversationFacotry.CreateConversationId only once  #1322

Closed
@tomlm

Description

@tomlm

Port this change from botbuilder-dotnet/master branch:
microsoft/botbuilder-dotnet#4382

Refactored SkillDialog to call the factory only during begin and store the generated conversationId in state to be used in subsequent calls to the skill.

Needs parity for python and JS

Fixes #4374

Changed projects

  • Microsoft.Bot.Builder.Dialogs
  • Microsoft.Bot.Builder.Dialogs.Tests

Metadata

Metadata

Assignees

No one assigned

    Labels

    P0Must Fix. Release-blockerR10Release 10 - August 17th, 2020

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions