Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore node_modules declarative assets #3709

Merged
merged 1 commit into from
May 26, 2021
Merged

fix: ignore node_modules declarative assets #3709

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions libraries/botbuilder-dialogs-adaptive-runtime/src/configurationResourceExplorer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,25 +2,20 @@
// Licensed under the MIT License.

import { Configuration } from './configuration';
import { ComponentDeclarativeTypes, FolderResourceProvider, ResourceExplorer } from 'botbuilder-dialogs-declarative';
import { ComponentDeclarativeTypes, ResourceExplorer } from 'botbuilder-dialogs-declarative';
import { ok } from 'assert';

export class ConfigurationResourceExporer extends ResourceExplorer {
private readonly folderResourceProvider: FolderResourceProvider;

constructor(configuration: Configuration, declarativeTypes: ComponentDeclarativeTypes[]) {
super({ declarativeTypes });

const applicationRoot = configuration.string(['applicationRoot']);
ok(applicationRoot);

this.folderResourceProvider = new FolderResourceProvider(
this,
this.addFolders(
applicationRoot,
true,
['node_modules'], // Composer copies to `dialogs/imported` so `node_modules` will contain dupes
mdrichardson marked this conversation as resolved.
Show resolved Hide resolved
configuration.string(['NODE_ENV']) === 'dev' // watch in dev only!
);

this.addResourceProvider(this.folderResourceProvider);
}
}