fix: ignore node_modules declarative assets #3709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libraries/botbuilder-dialogs-adaptive-runtime/src/configurationResourceExplorer.ts
Show resolved
Hide resolved
Pull Request Test Coverage Report for Build 879125975
💛 - Coveralls |
mdrichardson
approved these changes
May 26, 2021
joshgummersall
added a commit
that referenced
this pull request
May 26, 2021
joshgummersall
added a commit
that referenced
this pull request
May 26, 2021
joshgummersall
added a commit
that referenced
this pull request
May 27, 2021
* fix: named pipe issues (#3627) * fix: named pipe issues - Remove unnecessary autoReconnect logic - Simplify connection management - Properly support client reconnection to incoming/outgoing servers * fix: PR comments, failing tests * fix: "lock" sockets to mitigate split brain * test: no split brain * fix: reject listening only if server is listening * fix: naming for clarity * fix: clarify onListen doc string * feat: retry helper, use for named pipes * fix: handle retry edge cases * bump: adal-node to 0.2.2 (#3705) Fixes #3704 * fix: ignore node_modules declarative assets (#3709) See microsoft/BotFramework-Composer#7916 for details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3710