Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: auto-disable telemetry for schema tests #3688

Merged
merged 3 commits into from
May 14, 2021
Merged

fix: auto-disable telemetry for schema tests #3688

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e98ea45
auto-disable telemetry for schema tests
mdrichardson May 13, 2021
ce135bd
remove accidental double-period
mdrichardson May 13, 2021
f0a5246
pass env directly to exec
mdrichardson May 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions libraries/botbuilder-dialogs-declarative/tests/schemaMergeTest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,12 @@ const exec = util.promisify(require('child_process').exec);
// Note: This file is intentionally not named *.test.js to ensure it isn't run
// via `yarn run test` or `npm run test`.

async function runCommand(command) {
const { stdout, stderr } = await exec(command);
async function runCommand(command, envObject) {
// We need to combine our process.env with envObject so,
// 1) We can use existing env vars (like from CI), and
// 2) npx doesn't like to install without the existing APPDATA windows env var.
const env = { ...process.env, ...envObject };
const { stdout, stderr } = await exec(command, { env });

if (stderr) {
throw new Error(stderr);
Expand Down Expand Up @@ -64,13 +68,19 @@ describe('Schema Merge Tests', function () {
// Try installing latest bf if the schema changed to make sure the
// discrepancy is not because we are using a different version of the CLI
// and we ensure it is installed while on it.

try {
// Rerun merge command.
await runCommand(
[
'npx -p @microsoft/botframework-cli@next', // invoke with npx to not alter repo dependencies
...mergeCommand,
].join(' ')
].join(' '),
{
// When installing bf-cli, there is sometimes a prompt during install to allow telemetry.
// We need to set an environment variable so the prompt doesn't appear and halt install, causing a timeout.
BF_CLI_TELEMETRY: true,
}
);
} catch (err2) {
assert.fail(`Unable to merge schemas.\nFirst error:\n${err}\nSecond error:\n${err2}`);
Expand Down