Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auto-disable telemetry for schema tests #3688

Merged
merged 3 commits into from
May 14, 2021

Conversation

mdrichardson
Copy link
Contributor

Fixes #3687

Description

When installing bf-cli, there is sometimes a prompt during install to allow telemetry.
We need to set an environment variable so the prompt doesn't appear and halt install, causing a timeout.

See: https://github.com/microsoft/botframework-cli#enable-telemetry-in-continuous-integration-pipelines

@mdrichardson mdrichardson requested review from a team as code owners May 13, 2021 18:41
@mdrichardson mdrichardson changed the title auto-disable telemetry for schema tests fix: auto-disable telemetry for schema tests May 13, 2021
@coveralls
Copy link

coveralls commented May 13, 2021

Pull Request Test Coverage Report for Build 842600150

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 85.441%

Totals Coverage Status
Change from base Build 839554326: 0.04%
Covered Lines: 19217
Relevant Lines: 21394

💛 - Coveralls

Copy link
Contributor

@joshgummersall joshgummersall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beauty!

@mdrichardson mdrichardson merged commit 49f1b23 into microsoft:main May 14, 2021
@mdrichardson mdrichardson deleted the bfCliTelemDisable branch May 14, 2021 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BF-CLI telemetry prompt can cause timeout for schema tests
3 participants