Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherrypick: port resume dialog fix from .net (#3525) #3535

Merged
merged 1 commit into from
Apr 6, 2021
Merged

cherrypick: port resume dialog fix from .net (#3525) #3535

merged 1 commit into from
Apr 6, 2021

Conversation

joshgummersall
Copy link
Contributor

Fixes #3524

@joshgummersall joshgummersall requested review from stevengum and a team as code owners April 6, 2021 17:31
@coveralls
Copy link

coveralls commented Apr 6, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 723370315

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 217 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.01%) to 84.936%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-dialogs-adaptive/src/input/inputDialog.ts 8 89.04%
libraries/botbuilder-core/src/skills/skillConversationIdFactory.ts 9 17.39%
libraries/botbuilder-dialogs/src/skillDialog.ts 14 84.66%
libraries/botbuilder-dialogs-adaptive/src/adaptiveDialog.ts 186 38.7%
Totals Coverage Status
Change from base Build 720051946: -0.01%
Covered Lines: 18900
Relevant Lines: 21190
💛 - Coveralls

@stevengum stevengum merged commit f6cd3b0 into 4.13 Apr 6, 2021
@stevengum stevengum deleted the jpg/4.13-cherrypick branch April 6, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@luhan2017 luhan2017 Awaiting requested review from luhan2017

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshgummersall @coveralls @stevengum