Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port: resume dialog fix from .net #3525

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Conversation

joshgummersall
Copy link
Contributor

Fixes #3524

@coveralls
Copy link

coveralls commented Apr 6, 2021

Pull Request Test Coverage Report for Build 721154294

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 221 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.001%) to 84.931%

Files with Coverage Reduction New Missed Lines %
libraries/adaptive-expressions/src/triggerTrees/trigger.ts 4 62.21%
libraries/botbuilder-dialogs-adaptive/src/input/inputDialog.ts 8 89.04%
libraries/botbuilder-core/src/skills/skillConversationIdFactory.ts 9 17.39%
libraries/botbuilder-dialogs/src/skillDialog.ts 14 84.66%
libraries/botbuilder-dialogs-adaptive/src/adaptiveDialog.ts 186 38.7%
Totals Coverage Status
Change from base Build 720147895: -0.001%
Covered Lines: 18969
Relevant Lines: 21276

💛 - Coveralls

Copy link
Contributor

@gabog gabog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@@ -0,0 +1,148 @@
{
"$schema": "../../../tests.schema",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems odd, @Danieladu @chon219 @joshgummersall is there a reason we don't have a central version of this test.schema hosted somewhere? (Like https://schemas.botframework.com/schemas/component/v1.0/component.schema)

Not blocking on this comment, just wondering if this can be tightened up. Especially since the JS SDK's AdaptiveDialog/Declarative parity is closer than it's ever been with the .NET SDK.

@stevengum stevengum merged commit 6bd641e into main Apr 6, 2021
@stevengum stevengum deleted the jpg/port-resume-dialog-fix branch April 6, 2021 17:12
joshgummersall added a commit that referenced this pull request Apr 6, 2021
stevengum pushed a commit that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port: ResumeDialog is not called after resumption with adaptivedialog (#5426)
4 participants