Skip to content

port: remove lang from set speak middleware #3510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 1, 2021
Merged

port: remove lang from set speak middleware #3510

merged 2 commits into from
Apr 1, 2021

Conversation

@joshgummersall
Copy link
Contributor

@joshgummersall joshgummersall commented Apr 1, 2021

Fixes #3507

@joshgummersall joshgummersall requested review from a team as code owners April 1, 2021 14:47
@joshgummersall joshgummersall force-pushed the jpg/set-speak-remove-lang branch from b84cfc9 to 4a4f449 Compare April 1, 2021 14:58
@joshgummersall joshgummersall force-pushed the jpg/set-speak-remove-lang branch from 4a4f449 to 31c42cc Compare April 1, 2021 15:08
@coveralls
Copy link

coveralls commented Apr 1, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 709133113

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.004%) to 84.944%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder/src/setSpeakMiddleware.ts 1 81.36%
Totals Coverage Status
Change from base Build 709129245: -0.004%
Covered Lines: 18895
Relevant Lines: 21181
💛 - Coveralls

@joshgummersall joshgummersall merged commit 6724fcf into main Apr 1, 2021
@joshgummersall joshgummersall deleted the jpg/set-speak-remove-lang branch April 1, 2021 16:37
joshgummersall added a commit that referenced this pull request Apr 1, 2021
@joshgummersall @stevengum
port: remove lang from set speak middleware (#3510)
102c971 
Fixes #3507

Co-authored-by: Steven Gum <14935595+stevengum@users.noreply.github.com>
joshgummersall added a commit that referenced this pull request Apr 1, 2021
@joshgummersall @stevengum
cherrypick: runtypes lock and set speak middleware fixes (#3511)
f97b675 
* fix: lock runtypes to 5.1.x version range (#3509)

* port: remove lang from set speak middleware (#3510)

Fixes #3507

Co-authored-by: Steven Gum <14935595+stevengum@users.noreply.github.com>

Co-authored-by: Steven Gum <14935595+stevengum@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevengum stevengum stevengum approved these changes

@Stevenic Stevenic Awaiting requested review from Stevenic

@chrimc62 chrimc62 Awaiting requested review from chrimc62

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

port: SetSpeakMiddleware - remove lang argument (#5404)

4 participants

@joshgummersall @coveralls @stevengum