Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherrypick: runtypes lock and set speak middleware fixes #3511

Merged
merged 2 commits into from
Apr 1, 2021
Merged

cherrypick: runtypes lock and set speak middleware fixes #3511

merged 2 commits into from
Apr 1, 2021

Conversation

joshgummersall
Copy link
Contributor

Cherrypick some more commits.

joshgummersall and others added 2 commits April 1, 2021 10:02
@joshgummersall
fix: lock runtypes to 5.1.x version range (#3509)
83e7fb0
@joshgummersall @stevengum
port: remove lang from set speak middleware (#3510)
102c971 
Fixes #3507

Co-authored-by: Steven Gum <14935595+stevengum@users.noreply.github.com>
@joshgummersall joshgummersall requested review from stevengum and a team as code owners April 1, 2021 17:03
stevengum
stevengum approved these changes Apr 1, 2021
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@coveralls
Copy link

coveralls commented Apr 1, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 709249694

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 84.907%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder/src/setSpeakMiddleware.ts 1 81.36%
libraries/adaptive-expressions/src/triggerTrees/node.ts 8 91.7%
Totals Coverage Status
Change from base Build 706204366: -0.05%
Covered Lines: 18887
Relevant Lines: 21181
💛 - Coveralls

@joshgummersall joshgummersall merged commit f97b675 into 4.13 Apr 1, 2021
@joshgummersall joshgummersall deleted the jpg/4.13-cherrypick branch April 1, 2021 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@luhan2017 luhan2017 Awaiting requested review from luhan2017

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshgummersall @coveralls @stevengum