Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Orchestrator Recognizer: Rename misleading parameter names #3251

Merged
merged 3 commits into from
Feb 3, 2021
Merged

Orchestrator Recognizer: Rename misleading parameter names #3251

merged 3 commits into from
Feb 3, 2021

Conversation

daveta
Copy link
Contributor

@daveta daveta commented Feb 1, 2021 •
edited
Loading

Note: This checkin associated with :

  • C# Orchestrator recognizer update (dotnet pr)
  • A samples update that uses Orchestrator recognizer (samples pr)
  • Composer updates (@taicchoumsft : Will submit once new SDK released)
  • bf-cli updated (@tsuwandy checked in updates)

Description

From the first preview, we've received feedback that our parameter names are confusing.

Specific Changes

This performs the following parameter renames:
modelPath => modelFolder
snapshotPath => snapshotFile

Testing

Tests have been updated to reflect new parameter names.

@daveta daveta mentioned this pull request Feb 1, 2021
Merged
@coveralls
Copy link

coveralls commented Feb 1, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 531404706

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 84.691%
Totals Coverage Status
Change from base Build 529161273: 0.01%
Covered Lines: 18200
Relevant Lines: 20503
💛 - Coveralls

@daveta daveta mentioned this pull request Feb 2, 2021
Merged
@daveta daveta requested a review from tsuwandy February 2, 2021 17:05
@daveta daveta marked this pull request as ready for review February 2, 2021 17:05
@daveta daveta requested review from chrimc62, tomlm and a team as code owners February 2, 2021 17:05
@EricDahlvang EricDahlvang merged commit b7a668a into main Feb 3, 2021
@EricDahlvang EricDahlvang deleted the daveta/orch-rename branch February 3, 2021 01:45
This was referenced Feb 3, 2021
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsuwandy tsuwandy tsuwandy approved these changes

@EricDahlvang EricDahlvang EricDahlvang approved these changes

@taicchoumsft taicchoumsft taicchoumsft approved these changes

@darrenj darrenj Awaiting requested review from darrenj

@chrimc62 chrimc62 Awaiting requested review from chrimc62

@tomlm tomlm Awaiting requested review from tomlm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@daveta @coveralls @tsuwandy @EricDahlvang @taicchoumsft