Skip to content

port: Orchestrator Recognizer: Rename misleading parameter names (#5147) #3256

Closed

Description

The changes in Orchestrator Recognizer: Rename misleading parameter names (#5147) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Note: This checkin associated with :
  • Nodejs Orchestrator recognizer update (nodejs pr)
  • A samples update that uses Orchestrator recognizer (samples pr)
  • Composer updates (@taicchoumsft : Will submit once new SDK released)
  • bf-cli updated (@tsuwandy checked in updates)

Description

From the first preview, we've received feedback that our parameter names are confusing.

Specific Changes

This performs the following parameter renames:
modelPath => modelFolder
snapshotPath => snapshotFile

Testing

Tests have been updated to reflect new parameter names.

Please review and, if necessary, port the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    ExemptFromDailyDRIReportUse this label to exclude the issue from the DRI report.needs-triageThe issue has just been created and it has not been reviewed by the team.parityThe issue describes a gap in parity between two or more platforms.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions