This repository was archived by the owner on Jan 5, 2026. It is now read-only.
Teams Adaptive Card Tabs #3224
Merged
Teams Adaptive Card Tabs #3224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdrichardson
commented
Jan 26, 2021
mdrichardson
commented
Jan 26, 2021
Pull Request Test Coverage Report for Build 534338094
💛 - Coveralls |
joshgummersall
suggested changes
Jan 27, 2021
Contributor
joshgummersall
left a comment
joshgummersall
left a comment
There was a problem hiding this comment.
One quick change around tests, otherwise looks good.
stevengum
suggested changes
Jan 27, 2021
libraries/botbuilder-dialogs-adaptive-teams/src/conditions/onTeamsTabFetch.ts
Outdated
Show resolved
Hide resolved
libraries/botbuilder-dialogs-adaptive-teams/tests/actionTests.test.ts
Outdated
Show resolved
Hide resolved
joshgummersall
approved these changes
Jan 27, 2021
Contributor
|
Totally removing myself from the list of reviewers for this - all defer to ya'll experts. |
Contributor
|
@clearab I think your insight would be helpful here: #3224 (comment) |
stevengum
suggested changes
Jan 29, 2021
Member
stevengum
left a comment
stevengum
left a comment
There was a problem hiding this comment.
One last bit of feedback, otherwise this looks good to go.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3176
Notes
testsfolder was undertests/tests