Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Teams Adaptive Card Tabs #3224

Merged
merged 19 commits into from
Feb 3, 2021
Merged

Teams Adaptive Card Tabs #3224

merged 19 commits into from
Feb 3, 2021

Conversation

mdrichardson
Copy link
Contributor

Fixes #3176

Notes

  • Schema is copy/paste from @EricDahlvang's PR
  • Adaptive tests match between JS and .NET SDKs. Lots of small changes because of this.
  • Sorry for all the "File renamed without changes." I noticed the whole tests folder was under tests/tests

@mdrichardson mdrichardson requested review from chrimc62, tomlm and a team as code owners January 26, 2021 23:05
@mdrichardson mdrichardson changed the title sync schemas Teams Adaptive Card Tabs Jan 26, 2021
@coveralls
Copy link

coveralls commented Jan 26, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 534338094

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 84.685%
Files with Coverage Reduction New Missed Lines %
libraries/adaptive-expressions/src/triggerTrees/trigger.ts 2 63.08%
Totals Coverage Status
Change from base Build 534349860: 0.05%
Covered Lines: 18212
Relevant Lines: 20518
💛 - Coveralls

joshgummersall
joshgummersall suggested changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@joshgummersall joshgummersall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick change around tests, otherwise looks good.

libraries/botbuilder/tests/teamsActivityHandler.test.js Outdated Show resolved Hide resolved
@mdrichardson mdrichardson mentioned this pull request Jan 27, 2021
Closed
@clearab clearab removed their request for review January 27, 2021 19:31
@clearab
Copy link
Contributor

clearab commented Jan 27, 2021

Totally removing myself from the list of reviewers for this - all defer to ya'll experts.

@joshgummersall
Copy link
Contributor

@clearab I think your insight would be helpful here: #3224 (comment)

@joshgummersall joshgummersall added this to the R12 milestone Jan 29, 2021
stevengum
stevengum requested changes Jan 29, 2021
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last bit of feedback, otherwise this looks good to go.

libraries/botframework-schema/src/teams/index.ts Outdated Show resolved Hide resolved
stevengum
stevengum approved these changes Feb 3, 2021
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevengum stevengum merged commit f8b1ea7 into microsoft:main Feb 3, 2021
@mdrichardson mdrichardson deleted the teamsTabs branch February 3, 2021 18:04
@stevengum stevengum mentioned this pull request Feb 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clearab clearab clearab left review comments

@EricDahlvang EricDahlvang EricDahlvang left review comments

@joshgummersall joshgummersall joshgummersall approved these changes

@stevengum stevengum stevengum approved these changes

@chrimc62 chrimc62 Awaiting requested review from chrimc62

@tomlm tomlm Awaiting requested review from tomlm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
R12
Development

Successfully merging this pull request may close these issues.

Adaptive Card Tabs (JS)
6 participants
@mdrichardson @coveralls @clearab @joshgummersall @EricDahlvang @stevengum