Skip to content

Teams Adaptive Card Tabs #5111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 27, 2021
Merged

Teams Adaptive Card Tabs #5111

merged 10 commits into from
Jan 27, 2021

Conversation

EricDahlvang
Copy link
Member

Fixes #5081

@EricDahlvang EricDahlvang marked this pull request as ready for review January 21, 2021 19:09
@EricDahlvang EricDahlvang requested review from chrimc62, tomlm and a team as code owners January 21, 2021 19:09
@mrivera-ms
Copy link
Contributor

@chrimc62, could you please this?

@mrivera-ms
Copy link
Contributor

@johnataylor to review this.

mdrichardson
mdrichardson reviewed Jan 26, 2021
View reviewed changes
Michael Richardson added 2 commits January 26, 2021 13:48
@mdrichardson mdrichardson mentioned this pull request Jan 26, 2021
Merged
mrivera-ms
mrivera-ms reviewed Jan 26, 2021
View reviewed changes
libraries/Microsoft.Bot.Schema/Teams/Generated/TabResponseCard.cs Outdated
/// <summary>
/// Envelope for cards for a Tab request.
/// </summary>
public partial class TabResponseCard
Copy link
Contributor

@mrivera-ms mrivera-ms Jan 26, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

partial [](start = 11, length = 8)

Why is this partial? #Resolved

Copy link
Member Author

@EricDahlvang EricDahlvang Jan 27, 2021 •
edited by mrivera-ms
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many/most of the .schmea files are partial classes, and have a CustomInit which can be called during construction. I think this is part of the ServiceClient pattern. #Resolved

mrivera-ms
mrivera-ms reviewed Jan 26, 2021
View reviewed changes
mrivera-ms
mrivera-ms approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@mrivera-ms mrivera-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@EricDahlvang EricDahlvang merged commit cb33e75 into main Jan 27, 2021
@EricDahlvang EricDahlvang deleted the eric/teamsACTabs branch January 27, 2021 22:51
This was referenced Jan 27, 2021
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdrichardson mdrichardson mdrichardson left review comments

@johnataylor johnataylor johnataylor approved these changes

@mrivera-ms mrivera-ms mrivera-ms approved these changes

@chrimc62 chrimc62 Awaiting requested review from chrimc62

@tomlm tomlm Awaiting requested review from tomlm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adaptive Card Tabs (C#)
4 participants
@EricDahlvang @mrivera-ms @johnataylor @mdrichardson