Add node20 execution handler
#4240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Commenter does not have sufficient privileges for PR 4240 in repo microsoft/azure-pipelines-agent |
|
Node v20 has now been released: https://nodejs.org/en/blog/release/v20.0.0 |
9 tasks
|
Thanks @JamieMagee for supporting node 20, I just had another PR #4344, looks that its duplicated. Are there any plans to check this PR in so that we can update other tasks to node 20 in microsoft/azure-pipelines-tasks#18568 pipelines tasks repo? |
qianz2
reviewed
Jul 6, 2023
| @@ -55,10 +55,11 @@ public sealed class NodeHandler : Handler, INodeHandler | |||
| private const string nodeFolder = "node"; | |||
| private const string node10Folder = "node10"; | |||
| private const string node16Folder = "node16"; | |||
| private const string node20Folder = "node20"; | |||
| private const string nodeLTS = node16Folder; | |||
There was a problem hiding this comment.
Do we need to update nodeLTS?
There was a problem hiding this comment.
Node 20 isn't considered LTS until 24th October1
Footnotes
qianz2
reviewed
Jul 6, 2023
| @@ -11,6 +11,7 @@ NODE_URL=https://nodejs.org/dist | |||
| NODE_VERSION="6.17.1" | |||
| NODE10_VERSION="10.24.1" | |||
| NODE16_VERSION="16.17.1" | |||
| NODE20_VERSION="20.0.0" | |||
There was a problem hiding this comment.
The latest node 20 version is now 20.3.1: https://nodejs.org/en/download/current
|
Closing as #4344 was merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for running tasks using Node 20. Support for Node 16 is ending 6 months earlier than originally advertised, to coincide with the end-of-life of OpenSSL 1.1.11.
The table below shows the versions of Node currently used to run tasks, and their upstream support status2:
An earlier PR, adding support for Node 18, was closed in favour of Node 16 due to Node 18 requiring glibc 2.28, while Ubuntu 18.04 only supplied glibc 2.273. But this is no longer an issue as Ubuntu 18.04 is no longer supported as of 2023-04-034, and Ubuntu 20.04 ships with glibc 2.315.
Related to #4239. Followed #3861 for guidance.
Footnotes
https://nodejs.org/en/blog/announcements/nodejs16-eol ↩
https://endoflife.date/nodejs ↩
https://github.com/microsoft/azure-pipelines-agent/pull/3849#issuecomment-1173989948 ↩
https://github.com/actions/runner-images/issues/6002 ↩
https://packages.ubuntu.com/source/focal/glibc ↩