-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added node16 execution handler #3861
Conversation
…ttps://github.com/anatolybolshakov/azure-pipelines-agent into users/anatolybolshakov/feature-add-node18-handler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the comments
Could you please update the PR description as well? |
….com/microsoft/azure-pipelines-agent into users/v-andivanov/add-node16-handler
Done |
Migrated taskCopyFiles, UsePythonVersion, CMake Environment used (OS/Agent)Windows 10x64 / Agent with Node 16 handler, Ubuntu 16.04x64 / Agent with Node 16 handler, macOS 12 / Agent with Node 16 handler Test cases
|
….com/microsoft/azure-pipelines-agent into users/v-andivanov/add-node16-handler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and please take a look at the comment below
…-agent into users/v-andivanov/add-node16-handler
* Added node18 execution handler * Added node18 execution handler * Reworked tests * Fixed typo * Fixed typo in tests * Fixed node path selection logic * change to node16 * added knob for Node16 * corrected according to review * improved log tracing * improve code * update version Co-authored-by: Anatolii Bolshakov (Akvelon INC) <v-anbols@microsoft.com> Co-authored-by: Andrey Ivanov <v-andivanov@microsoft.com> Co-authored-by: Alexander Smolyakov <sphinx414@gmail.com>
…d folders from Node distribution (#3899) * Added node16 execution handler (#3861) * remove npx in the node 10 directory; remove npm, npx, corepack, and related node modules in the node 16 directory (#3897) * Update dotnet scripts (#3895) * Agent Release 2.206.1 Co-authored-by: AndreyIvanov42 <93121155+AndreyIvanov42@users.noreply.github.com> Co-authored-by: Anatolii Bolshakov (Akvelon INC) <v-anbols@microsoft.com> Co-authored-by: Andrey Ivanov <v-andivanov@microsoft.com> Co-authored-by: Denis Rumyantsev <mr.denis.rumyantsev@gmail.com> Co-authored-by: Lilia Sabitova <lilia.sabitova@ua.akvelon.com>
Task description:
Added node16 execution handler - to be able to execute tasks using this version.
Mostly similar to #3103
Changelog
Testing
by unit-tests
manually as part of some task. Used tasks and cases are described here