Skip to content

metrics tree scroll issue fixed - #20758

Merged
James Newton-King (JamesNK) merged 1 commit into
microsoft:mainfrom
heyysiri:fix/metrics-tree-scroll
Oct 6, 2026
Merged

James Newton-King (JamesNK) merged 1 commit into
microsoft:mainfrom
heyysiri:fix/metrics-tree-scroll

Conversation

@heyysiri

Copy link
Copy Markdown
Contributor

Description

Problem

On the Metrics page, the left-hand meter/instrument tree can't be scrolled when it's taller than the window. There's no scrollbar and the mouse wheel does nothing, so instruments below the fold can't be reached.

This regressed when the dashboard moved to Fluent UI Blazor v5 in #19431. The v4 FluentSplitter gave each panel its own scroll container. The v5 FluentMultiSplitterPane doesn't. The chart pane already got overflow: auto in that migration, but the tree pane didn't.

Change

In Metrics.razor.css, the existing overflow: auto rule for the chart pane now also applies to the pane that contains the metric tree (.metrics-tree).

Verification

  • Before the change: the tree pane is overflow: hidden; a mouse-wheel scroll leaves it at the top.
  • After the change: the pane scrolls and the lower meters come into view.
  • Checked in Brave.
image
  • CSS-only change. No behavior change on the chart side.
  • Not covered by automated tests. The existing dashboard tests don't check layout.

Fixes #20728

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • No
  • Did you add public API?
    • No
  • Does the change make any security assumptions or guarantees?
    • No

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 20758

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 20758"

@JamesNK

Copy link
Copy Markdown
Member

Thanks! Will try to get this fix out ASAP

@JamesNK

Copy link
Copy Markdown
Member

/backport to release/13.6

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Started backporting to release/13.6 (link to workflow run)

@JamesNK
James Newton-King (JamesNK) merged commit f733f6f into microsoft:main Oct 6, 2026
156 checks passed
@microsoft-github-policy-service microsoft-github-policy-service Bot added this to the 17.0 milestone Oct 6, 2026
Jose Perez Rodriguez (joperezr) pushed a commit that referenced this pull request Oct 6, 2026
Backport of #20758 to release/13.6

/cc @JamesNK @heyysiri

## Customer Impact

In Aspire 13.6, the Metrics page's meter/instrument tree cannot be
scrolled when it exceeds the viewport, preventing customers from
reaching and selecting metrics below the fold.

## Testing

Manually verified in Brave that the pane does not scroll before the
change and that mouse-wheel scrolling reveals lower meters after the
change. No automated test was added because existing dashboard tests do
not validate visual layout.

## Risk

Low. This is a localized CSS change that applies the chart pane's
existing `overflow: auto` behavior to the metrics tree pane.

## Regression?

Yes — introduced by the Fluent UI Blazor v5 migration in #19431.

Co-authored-by: heyysiri <siriraj2004@gmail.com>
This was referenced Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Metrics don't offer a scrollbar, can't scroll down.

2 participants