This repository was archived by the owner on May 28, 2025. It is now read-only.
Cherry pick 11 02 #1309
Merged
Cherry pick 11 02 #1309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix rotation and nslayout line drawing * Remove descent and add comment * Add CTCatalog page for testing CTM transformation * Add new test page to xcodeproj * Address CR feedback * Remove vestigial colorspace Fixes incorrect rotation introduced by my recent math changes and adds descent to nslayoutmanager line drawing to make exclusion zones more accurate Fixes microsoft#1275
…s. (microsoft#1295) The heap corruption happened in an internal test app. The fix is to use BGRX pixel format for opaque layers - this is supported by WIC render target.
It seems our drawing implementation was overcomplicated, doing unnecessary transformations which made assumptions about the state of the context which were not always true. Removes now unnecessary private drawing functions and removes ascent as well as simplifying CGContextDrawGlyphRun. Fixes microsoft#1290
…ft#1302) Update from using simplistic mapping using the font's symbolic traits, which ignored stretch, to getting the weight/stretch/style directly from the font. UILabel-rendered narrow or condensed fonts were previously clipped at the sides because the CoreText-calculated width would be for a narrow font, but UILabel would attempt to render a normal font.
* Fix infinite loop in __CreateDWriteTextLayout * Clang format acting up
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick ship blockers to maser for 11/7 release.
This change is