Fix rotation and nslayout line drawing #1274
Conversation
|
|
||
| CGFloat ascent, leading; | ||
| CGFloat ascent, descent, leading; | ||
| CTLineGetTypographicBounds(line, &ascent, nullptr, &leading); |
There was a problem hiding this comment.
nullptr, [](start = 50, length = 8)
you're not currently getting the descent though, so it doesn't look like this would've changed anything?
There was a problem hiding this comment.
(i think ascent + leading would've been correct here in any case)
In reply to: 85786676 [](ancestors = 85786676)
There was a problem hiding this comment.
You're right, added a comment and reverted change
There was a problem hiding this comment.
nit: I would probably just make the comment be about what the SetTextPosition is actually doing? "because CG origin is the opposite vertically from UIKit origin, flip the y line origin from upper left corner to lower left corner (baseline)", except use better wording than i did
In reply to: 85789609 [](ancestors = 85789609)
|
|
||
| // Perform anti-clockwise rotation required to match the reference platform. | ||
| imgRenderTarget->SetTransform(D2D1::Matrix3x2F(transform.a, -transform.b, transform.c, transform.d, transform.tx, -transform.ty)); | ||
| imgRenderTarget->SetTransform(D2D1::Matrix3x2F(transform.a, -transform.b, -transform.c, transform.d, transform.tx, -transform.ty)); |
There was a problem hiding this comment.
-transform.c [](start = 78, length = 12)
i'd been wondering for a while why this was missing...
There was a problem hiding this comment.
I'm not quite sure how it worked before
|
|
rajsesh
left a comment
rajsesh
left a comment
There was a problem hiding this comment.
Good catch. Please add a page to CTCatalog for rotate. Also I'd like to start adding automated tests that validate the contents of bitmap context to catch regressions that would be easy to miss with untrained eye.
| <AppxManifest Include="Package.appxmanifest"> | ||
| <SubType>Designer</SubType> | ||
| </AppxManifest> | ||
| <ClangCompile Include="..\..\CTCatalog\Tests\CTCAffineTransformationTestViewController.mm" /> |
There was a problem hiding this comment.
These files also need to be added to xcodeproject and should compile and run on reference platform.
There was a problem hiding this comment.
Already done and tested
| [_translateYSlider setNeedsDisplay]; | ||
| } | ||
|
|
||
| - (void)didReceiveMemoryWarning { |
There was a problem hiding this comment.
these functions can be deleted.
|
|
||
| #import "CTCAffineTransformationTestViewController.h" | ||
|
|
||
| static const NSString* text = @"The quick brown dog jumps over the lazy fox. THE QUICK BROWN DOG JUMPS OVER THE LAZY FOX."; |
There was a problem hiding this comment.
I would change this text to read what the expected test result should be (changing rotate should cause the text to rotate in which direction?).
|
|
||
| setting.spec = kCTParagraphStyleSpecifierAlignment; | ||
| setting.valueSize = sizeof(CTTextAlignment); | ||
| CTTextAlignment alignment = kCTCenterTextAlignment; |
There was a problem hiding this comment.
left alignment here to easily see the pivot point?
ms-jihua
left a comment
ms-jihua
left a comment
There was a problem hiding this comment.
nit: it'd be nice if the sliders had labels, but it's fine as-is
|
|
||
| // Creates outline | ||
| CGContextSetLineWidth(context, 2.0); | ||
| CGColorSpaceRef colorspace = CGColorSpaceCreateDeviceRGB(); |
There was a problem hiding this comment.
This colorspace does not seem to be used.
* Fix rotation and nslayout line drawing * Remove descent and add comment * Add CTCatalog page for testing CTM transformation * Add new test page to xcodeproj * Address CR feedback * Remove vestigial colorspace Fixes incorrect rotation introduced by my recent math changes and adds descent to nslayoutmanager line drawing to make exclusion zones more accurate Fixes microsoft#1275
5 participants
Fixes incorrect rotation introduced by my recent math changes and adds descent to nslayoutmanager line drawing to make exclusion zones more accurate
Fixes #1275
This change is