Skip to content

Ensure findPrecedingToken recurses into JSDoc children when needed #53487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 12, 2023
Merged

Ensure findPrecedingToken recurses into JSDoc children when needed #53487

merged 3 commits into from
Apr 12, 2023

Conversation

jakebailey
Copy link
Member

Fixes #53476

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Mar 24, 2023
@jakebailey
Copy link
Member Author

@typescript-bot user test tsserver
@typescript-bot test tsserver top100
@typescript-bot perf test this
@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 24, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the tarball bundle task on this PR at ab2eed3. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 24, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the diff-based top-repos suite (tsserver) on this PR at ab2eed3. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 24, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the perf test suite on this PR at ab2eed3. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 24, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the diff-based user code test suite (tsserver) on this PR at ab2eed3. You can monitor the build here.

Update: The results are in!

jakebailey
jakebailey commented Mar 24, 2023
View reviewed changes
@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 24, 2023 •
edited
Loading

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/150957/artifacts?artifactName=tgz&fileId=BA775AA801493E7721AF376F3BF807EDE76C8DA5A62E3C048B29A8872F6ADDC802&fileName=/typescript-5.1.0-insiders.20230324.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.1.0-pr-53487-5".;

@DanielRosenwasser
Copy link
Member

What caused the regression in the first place?

@jakebailey
Copy link
Member Author

#53476 says

5.0.2 and I can reproduce it in main. It probably occurred in older versions.

I can test 4.9 to double check, though.

@jakebailey
Copy link
Member Author

It hangs in 4.9 too, so this isn't a regression in 5.0 as far as I can tell.

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/53487/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..53487
Metric main 53487 Delta Best Worst p-value
Angular - node (v18.10.0, x64)
Memory used 362,093k (± 0.01%) 362,120k (± 0.00%) ~ 362,102k 362,150k p=0.065 n=6
Parse Time 3.40s (± 0.29%) 3.38s (± 0.41%) -0.03s (- 0.78%) 3.36s 3.39s p=0.011 n=6
Bind Time 1.12s (± 0.46%) 1.12s (± 0.49%) -0.01s (- 0.74%) 1.11s 1.12s p=0.038 n=6
Check Time 8.72s (± 0.28%) 8.70s (± 0.41%) ~ 8.65s 8.75s p=0.292 n=6
Emit Time 7.54s (± 0.57%) 7.47s (± 0.79%) ~ 7.38s 7.54s p=0.064 n=6
Total Time 20.78s (± 0.28%) 20.65s (± 0.44%) -0.13s (- 0.60%) 20.52s 20.77s p=0.024 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used 193,687k (± 1.63%) 194,560k (± 1.51%) ~ 190,752k 196,539k p=0.689 n=6
Parse Time 1.50s (± 0.60%) 1.49s (± 1.73%) ~ 1.45s 1.51s p=0.563 n=6
Bind Time 0.77s (± 0.97%) 0.77s (± 0.67%) ~ 0.76s 0.77s p=0.241 n=6
Check Time 9.66s (± 0.53%) 9.61s (± 0.24%) ~ 9.59s 9.65s p=0.092 n=6
Emit Time 2.73s (± 0.89%) 2.73s (± 0.45%) ~ 2.73s 2.76s p=1.000 n=6
Total Time 14.66s (± 0.53%) 14.60s (± 0.28%) ~ 14.55s 14.65s p=0.145 n=6
Monaco - node (v18.10.0, x64)
Memory used 346,449k (± 0.01%) 346,433k (± 0.01%) ~ 346,402k 346,474k p=0.336 n=6
Parse Time 2.60s (± 0.45%) 2.58s (± 1.11%) ~ 2.53s 2.61s p=0.288 n=6
Bind Time 1.00s (± 0.51%) 1.01s (± 0.74%) ~ 1.00s 1.02s p=0.069 n=6
Check Time 7.14s (± 0.44%) 7.10s (± 0.44%) -0.04s (- 0.51%) 7.07s 7.16s p=0.043 n=6
Emit Time 4.25s (± 0.59%) 4.22s (± 0.19%) -0.03s (- 0.71%) 4.21s 4.23s p=0.028 n=6
Total Time 14.99s (± 0.35%) 14.92s (± 0.34%) -0.07s (- 0.48%) 14.85s 15.00s p=0.045 n=6
TFS - node (v18.10.0, x64)
Memory used 300,672k (± 0.01%) 300,680k (± 0.00%) ~ 300,665k 300,702k p=0.422 n=6
Parse Time 2.08s (± 0.77%) 2.04s (± 1.14%) -0.04s (- 1.68%) 2.01s 2.07s p=0.023 n=6
Bind Time 1.14s (± 0.55%) 1.14s (± 1.06%) ~ 1.12s 1.15s p=0.673 n=6
Check Time 6.55s (± 0.48%) 6.56s (± 0.57%) ~ 6.50s 6.60s p=0.743 n=6
Emit Time 3.86s (± 0.35%) 3.86s (± 0.53%) ~ 3.83s 3.89s p=1.000 n=6
Total Time 13.63s (± 0.34%) 13.60s (± 0.44%) ~ 13.53s 13.67s p=0.462 n=6
material-ui - node (v18.10.0, x64)
Memory used 477,137k (± 0.01%) 477,156k (± 0.01%) ~ 477,107k 477,215k p=0.470 n=6
Parse Time 3.01s (± 2.10%) 3.05s (± 1.67%) ~ 2.95s 3.09s p=0.630 n=6
Bind Time 1.02s (± 7.50%) 0.94s (± 7.48%) ~ 0.90s 1.08s p=0.122 n=6
Check Time 17.45s (± 1.04%) 17.14s (± 0.57%) -0.31s (- 1.81%) 16.98s 17.25s p=0.016 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 21.48s (± 0.89%) 21.12s (± 0.42%) -0.36s (- 1.68%) 20.97s 21.21s p=0.008 n=6
xstate - node (v18.10.0, x64)
Memory used 552,893k (± 0.02%) 552,950k (± 0.02%) ~ 552,826k 553,052k p=0.378 n=6
Parse Time 3.80s (± 0.59%) 3.77s (± 0.60%) -0.03s (- 0.79%) 3.75s 3.80s p=0.042 n=6
Bind Time 1.71s (± 0.68%) 1.70s (± 0.53%) ~ 1.69s 1.71s p=0.114 n=6
Check Time 2.87s (± 0.92%) 2.85s (± 0.44%) ~ 2.84s 2.87s p=0.225 n=6
Emit Time 0.08s (± 0.00%) 0.08s (± 0.00%) ~ 0.08s 0.08s p=1.000 n=6
Total Time 8.47s (± 0.60%) 8.41s (± 0.29%) -0.06s (- 0.73%) 8.38s 8.45s p=0.019 n=6
Angular - node (v16.17.1, x64)
Memory used 361,441k (± 0.01%) 361,465k (± 0.01%) ~ 361,405k 361,515k p=0.298 n=6
Parse Time 3.52s (± 0.47%) 3.51s (± 0.64%) ~ 3.49s 3.54s p=0.461 n=6
Bind Time 1.19s (± 0.69%) 1.18s (± 0.46%) ~ 1.18s 1.19s p=0.859 n=6
Check Time 9.55s (± 0.55%) 9.56s (± 0.31%) ~ 9.53s 9.61s p=0.517 n=6
Emit Time 7.96s (± 0.99%) 7.96s (± 0.88%) ~ 7.90s 8.08s p=0.747 n=6
Total Time 22.22s (± 0.60%) 22.21s (± 0.27%) ~ 22.16s 22.32s p=1.000 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 193,061k (± 0.72%) 192,925k (± 0.51%) ~ 192,502k 194,949k p=0.378 n=6
Parse Time 1.58s (± 1.26%) 1.59s (± 0.86%) ~ 1.57s 1.61s p=0.180 n=6
Bind Time 0.82s (± 0.50%) 0.82s (± 0.63%) ~ 0.82s 0.83s p=0.595 n=6
Check Time 10.37s (± 0.65%) 10.29s (± 0.47%) -0.09s (- 0.85%) 10.22s 10.35s p=0.036 n=6
Emit Time 3.00s (± 0.86%) 2.99s (± 0.25%) ~ 2.98s 3.00s p=0.454 n=6
Total Time 15.78s (± 0.58%) 15.69s (± 0.35%) ~ 15.62s 15.76s p=0.078 n=6
Monaco - node (v16.17.1, x64)
Memory used 345,732k (± 0.01%) 345,725k (± 0.01%) ~ 345,693k 345,751k p=0.873 n=6
Parse Time 2.74s (± 1.32%) 2.72s (± 0.45%) ~ 2.71s 2.74s p=0.452 n=6
Bind Time 1.08s (± 1.26%) 1.08s (± 0.38%) ~ 1.08s 1.09s p=0.528 n=6
Check Time 7.82s (± 0.39%) 7.79s (± 0.47%) ~ 7.76s 7.86s p=0.145 n=6
Emit Time 4.48s (± 0.94%) 4.43s (± 0.42%) -0.05s (- 1.19%) 4.41s 4.46s p=0.019 n=6
Total Time 16.12s (± 0.54%) 16.02s (± 0.21%) -0.10s (- 0.63%) 15.99s 16.08s p=0.024 n=6
TFS - node (v16.17.1, x64)
Memory used 300,022k (± 0.01%) 300,027k (± 0.00%) ~ 300,019k 300,051k p=0.521 n=6
Parse Time 2.19s (± 0.80%) 2.17s (± 0.94%) ~ 2.16s 2.21s p=0.097 n=6
Bind Time 1.24s (± 1.18%) 1.24s (± 0.98%) ~ 1.22s 1.25s p=0.564 n=6
Check Time 7.22s (± 0.82%) 7.20s (± 0.34%) ~ 7.16s 7.23s p=0.871 n=6
Emit Time 4.32s (± 1.00%) 4.33s (± 1.00%) ~ 4.28s 4.41s p=0.872 n=6
Total Time 14.97s (± 0.64%) 14.94s (± 0.46%) ~ 14.85s 15.06s p=0.520 n=6
material-ui - node (v16.17.1, x64)
Memory used 476,422k (± 0.01%) 476,452k (± 0.00%) ~ 476,430k 476,490k p=0.148 n=6
Parse Time 3.20s (± 1.21%) 3.21s (± 0.95%) ~ 3.15s 3.24s p=0.629 n=6
Bind Time 0.97s (± 2.06%) 0.96s (± 1.43%) ~ 0.95s 0.99s p=0.864 n=6
Check Time 18.14s (± 0.63%) 18.15s (± 0.52%) ~ 18.04s 18.29s p=0.936 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.31s (± 0.48%) 22.32s (± 0.42%) ~ 22.21s 22.46s p=0.936 n=6
xstate - node (v16.17.1, x64)
Memory used 550,479k (± 0.01%) 550,545k (± 0.01%) ~ 550,488k 550,702k p=0.230 n=6
Parse Time 3.95s (± 0.49%) 3.95s (± 0.21%) ~ 3.94s 3.96s p=0.373 n=6
Bind Time 1.79s (± 0.82%) 1.80s (± 0.65%) ~ 1.79s 1.82s p=0.324 n=6
Check Time 3.11s (± 0.64%) 3.10s (± 0.35%) ~ 3.08s 3.11s p=0.280 n=6
Emit Time 0.09s (± 4.45%) 0.09s (± 0.00%) ~ 0.09s 0.09s p=0.405 n=6
Total Time 8.94s (± 0.36%) 8.93s (± 0.14%) ~ 8.92s 8.95s p=0.808 n=6
Angular - node (v14.15.1, x64)
Memory used 355,325k (± 0.00%) 355,343k (± 0.00%) ~ 355,324k 355,354k p=0.093 n=6
Parse Time 3.63s (± 0.81%) 3.60s (± 0.63%) ~ 3.58s 3.64s p=0.193 n=6
Bind Time 1.23s (± 0.89%) 1.23s (± 0.84%) ~ 1.21s 1.24s p=0.863 n=6
Check Time 9.92s (± 0.24%) 9.93s (± 0.33%) ~ 9.89s 9.97s p=0.418 n=6
Emit Time 8.36s (± 0.65%) 8.39s (± 1.00%) ~ 8.27s 8.49s p=0.574 n=6
Total Time 23.13s (± 0.20%) 23.15s (± 0.49%) ~ 22.98s 23.28s p=0.936 n=6
Compiler-Unions - node (v14.15.1, x64)
Memory used 187,755k (± 0.01%) 187,761k (± 0.01%) ~ 187,740k 187,784k p=0.575 n=6
Parse Time 1.61s (± 0.75%) 1.60s (± 0.92%) ~ 1.59s 1.62s p=0.357 n=6
Bind Time 0.85s (± 1.15%) 0.85s (± 0.61%) ~ 0.84s 0.85s p=0.386 n=6
Check Time 10.50s (± 0.73%) 10.50s (± 0.53%) ~ 10.43s 10.59s p=0.868 n=6
Emit Time 3.12s (± 0.43%) 3.13s (± 0.47%) ~ 3.12s 3.15s p=0.345 n=6
Total Time 16.07s (± 0.44%) 16.09s (± 0.38%) ~ 15.99s 16.17s p=1.000 n=6
Monaco - node (v14.15.1, x64)
Memory used 340,596k (± 0.01%) 340,616k (± 0.01%) ~ 340,595k 340,650k p=0.128 n=6
Parse Time 2.84s (± 0.35%) 2.83s (± 0.45%) ~ 2.81s 2.84s p=0.137 n=6
Bind Time 1.11s (± 0.95%) 1.10s (± 0.57%) ~ 1.09s 1.11s p=0.388 n=6
Check Time 8.17s (± 0.48%) 8.16s (± 0.43%) ~ 8.12s 8.22s p=0.629 n=6
Emit Time 4.68s (± 0.92%) 4.70s (± 0.81%) ~ 4.67s 4.76s p=0.335 n=6
Total Time 16.80s (± 0.36%) 16.80s (± 0.32%) ~ 16.73s 16.85s p=0.810 n=6
TFS - node (v14.15.1, x64)
Memory used 295,093k (± 0.01%) 295,099k (± 0.01%) ~ 295,078k 295,119k p=0.575 n=6
Parse Time 2.40s (± 0.73%) 2.39s (± 0.81%) ~ 2.37s 2.42s p=0.463 n=6
Bind Time 1.06s (± 0.38%) 1.07s (± 0.51%) ~ 1.06s 1.07s p=0.282 n=6
Check Time 7.52s (± 0.72%) 7.55s (± 0.22%) ~ 7.53s 7.58s p=0.288 n=6
Emit Time 4.30s (± 0.80%) 4.30s (± 0.39%) ~ 4.28s 4.32s p=0.935 n=6
Total Time 15.29s (± 0.38%) 15.31s (± 0.20%) ~ 15.27s 15.34s p=0.688 n=6
material-ui - node (v14.15.1, x64)
Memory used 471,990k (± 0.00%) 471,975k (± 0.01%) ~ 471,943k 472,013k p=0.575 n=6
Parse Time 3.36s (± 0.51%) 3.36s (± 0.41%) ~ 3.34s 3.37s p=0.568 n=6
Bind Time 1.01s (± 0.51%) 1.00s (± 0.98%) ~ 0.99s 1.01s p=0.417 n=6
Check Time 19.20s (± 0.61%) 19.15s (± 0.79%) ~ 18.90s 19.37s p=0.378 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 23.57s (± 0.49%) 23.51s (± 0.71%) ~ 23.24s 23.75s p=0.336 n=6
xstate - node (v14.15.1, x64)
Memory used 539,174k (± 0.00%) 539,162k (± 0.01%) ~ 539,118k 539,196k p=0.810 n=6
Parse Time 4.24s (± 0.41%) 4.21s (± 0.69%) ~ 4.19s 4.27s p=0.063 n=6
Bind Time 1.68s (± 0.58%) 1.67s (± 0.66%) ~ 1.66s 1.69s p=0.067 n=6
Check Time 3.22s (± 0.48%) 3.22s (± 0.64%) ~ 3.19s 3.25s p=0.802 n=6
Emit Time 0.09s (± 0.00%) 0.09s (± 0.00%) ~ 0.09s 0.09s p=1.000 n=6
Total Time 9.22s (± 0.14%) 9.19s (± 0.58%) ~ 9.15s 9.29s p=0.076 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 53487 6
Baseline main 6

TSServer

Comparison Report - main..53487
Metric main 53487 Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,402ms (± 0.64%) 2,403ms (± 0.78%) ~ 2,390ms 2,440ms p=0.936 n=6
Req 2 - geterr 5,525ms (± 0.37%) 5,526ms (± 0.53%) ~ 5,488ms 5,569ms p=0.936 n=6
Req 3 - references 338ms (± 1.66%) 336ms (± 0.71%) ~ 334ms 340ms p=0.808 n=6
Req 4 - navto 281ms (± 0.35%) 280ms (± 0.57%) ~ 278ms 282ms p=0.446 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 82ms (± 3.53%) 84ms (± 1.63%) ~ 81ms 85ms p=0.392 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,534ms (± 1.20%) 2,528ms (± 1.12%) ~ 2,500ms 2,567ms p=1.000 n=6
Req 2 - geterr 4,066ms (± 0.48%) 4,042ms (± 0.73%) ~ 4,010ms 4,088ms p=0.230 n=6
Req 3 - references 349ms (± 1.60%) 351ms (± 0.42%) ~ 349ms 353ms p=0.936 n=6
Req 4 - navto 289ms (± 0.68%) 290ms (± 0.56%) ~ 288ms 292ms p=0.325 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 78ms (± 7.29%) 82ms (± 4.59%) ~ 75ms 85ms p=0.193 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,026ms (± 0.64%) 3,004ms (± 0.33%) ~ 2,991ms 3,014ms p=0.054 n=6
Req 2 - geterr 1,695ms (± 1.79%) 1,689ms (± 0.82%) ~ 1,672ms 1,706ms p=1.000 n=6
Req 3 - references 107ms (± 0.59%) 107ms (± 0.97%) ~ 105ms 108ms p=0.654 n=6
Req 4 - navto 358ms (± 0.66%) 355ms (± 0.59%) ~ 353ms 358ms p=0.053 n=6
Req 5 - completionInfo count 2,861 (± 0.00%) 2,861 (± 0.00%) ~ 2,861 2,861 p=1.000 n=6
Req 5 - completionInfo 381ms (± 2.07%) 377ms (± 2.05%) ~ 366ms 385ms p=0.336 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,511ms (± 0.89%) 2,503ms (± 0.54%) ~ 2,483ms 2,521ms p=0.378 n=6
Req 2 - geterr 5,892ms (± 0.17%) 5,897ms (± 0.31%) ~ 5,876ms 5,927ms p=0.810 n=6
Req 3 - references 347ms (± 0.66%) 345ms (± 0.70%) ~ 343ms 349ms p=0.124 n=6
Req 4 - navto 279ms (± 0.27%) 278ms (± 0.37%) ~ 277ms 280ms p=0.351 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 74ms (± 1.57%) 74ms (± 1.02%) ~ 73ms 75ms p=0.396 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,676ms (± 0.51%) 2,668ms (± 0.88%) ~ 2,636ms 2,699ms p=0.575 n=6
Req 2 - geterr 4,438ms (± 0.36%) 4,423ms (± 0.47%) ~ 4,398ms 4,454ms p=0.149 n=6
Req 3 - references 365ms (± 0.24%) 363ms (± 0.51%) ~ 361ms 366ms p=0.121 n=6
Req 4 - navto 287ms (± 0.22%) 287ms (± 0.37%) ~ 285ms 288ms p=0.388 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 78ms (± 3.19%) 78ms (± 3.19%) ~ 76ms 81ms p=1.000 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,160ms (± 0.35%) 3,167ms (± 0.23%) ~ 3,155ms 3,174ms p=0.230 n=6
Req 2 - geterr 1,845ms (± 0.71%) 1,861ms (± 1.30%) ~ 1,832ms 1,905ms p=0.173 n=6
Req 3 - references 114ms (± 1.65%) 114ms (± 1.21%) ~ 112ms 116ms p=0.867 n=6
Req 4 - navto 342ms (± 0.39%) 342ms (± 0.60%) ~ 339ms 345ms p=0.605 n=6
Req 5 - completionInfo count 2,861 (± 0.00%) 2,861 (± 0.00%) ~ 2,861 2,861 p=1.000 n=6
Req 5 - completionInfo 393ms (± 1.06%) 391ms (± 0.66%) ~ 387ms 393ms p=0.422 n=6
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,607ms (± 0.52%) 2,600ms (± 0.56%) ~ 2,579ms 2,614ms p=0.575 n=6
Req 2 - geterr 6,353ms (± 0.48%) 6,351ms (± 0.25%) ~ 6,328ms 6,373ms p=0.873 n=6
Req 3 - references 362ms (± 0.52%) 365ms (± 0.86%) ~ 359ms 368ms p=0.147 n=6
Req 4 - navto 282ms (± 0.85%) 282ms (± 1.07%) ~ 279ms 287ms p=0.514 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 96ms (± 6.11%) 99ms (± 4.93%) ~ 90ms 103ms p=0.514 n=6
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,831ms (± 0.59%) 2,832ms (± 0.43%) ~ 2,815ms 2,853ms p=0.630 n=6
Req 2 - geterr 4,684ms (± 2.62%) 4,637ms (± 2.30%) ~ 4,542ms 4,774ms p=0.471 n=6
Req 3 - references 389ms (± 6.97%) 389ms (± 6.66%) ~ 369ms 425ms p=0.871 n=6
Req 4 - navto 289ms (± 1.08%) 290ms (± 1.09%) ~ 286ms 294ms p=0.871 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 80ms (± 9.99%) 80ms (± 9.73%) ~ 74ms 92ms p=1.000 n=6
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,458ms (± 0.44%) 3,447ms (± 0.49%) ~ 3,433ms 3,478ms p=0.199 n=6
Req 2 - geterr 1,869ms (± 1.26%) 1,889ms (± 1.15%) ~ 1,857ms 1,919ms p=0.173 n=6
Req 3 - references 125ms (± 0.60%) 124ms (± 0.88%) ~ 123ms 126ms p=0.131 n=6
Req 4 - navto 372ms (± 0.53%) 371ms (± 0.40%) ~ 369ms 373ms p=0.871 n=6
Req 5 - completionInfo count 2,861 (± 0.00%) 2,861 (± 0.00%) ~ 2,861 2,861 p=1.000 n=6
Req 5 - completionInfo 408ms (± 1.22%) 409ms (± 0.58%) ~ 405ms 412ms p=0.571 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 53487 6
Baseline main 6

Startup

Comparison Report - main..53487
Metric main 53487 Delta Best Worst p-value
tsc-startup - node (v16.17.1, x64)
Execution time 141.87ms (± 0.23%) 141.18ms (± 0.16%) -0.69ms (- 0.49%) 140.57ms 144.81ms p=0.000 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time 229.11ms (± 0.47%) 225.88ms (± 0.19%) -3.22ms (- 1.41%) 224.76ms 231.53ms p=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 230.78ms (± 0.38%) 227.81ms (± 0.15%) -2.97ms (- 1.29%) 226.73ms 232.41ms p=0.000 n=600
typescript-startup - node (v16.17.1, x64)
Execution time 210.94ms (± 0.35%) 208.64ms (± 0.17%) -2.30ms (- 1.09%) 207.68ms 214.51ms p=0.000 n=600
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 53487 6
Baseline main 6

Developer Information:

Download Benchmark

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/53487/merge:

Everything looks good!

DanielRosenwasser
DanielRosenwasser reviewed Mar 24, 2023
View reviewed changes
src/testRunner/unittests/services/utilities.ts
const core = window.Abcd.core;
})();`, ts.ScriptTarget.ESNext, /*setParentNodes*/ true);
// can't use ts.getTokenAtPosition because it returns back the wrong token
const param = ts.forEachChildRecursively(sourceFile, node => node.kind === ts.SyntaxKind.Parameter ? node : undefined)!;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what parameter is there in the example code?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, window??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea, I just copied and pasted the test from the issue...

DanielRosenwasser
DanielRosenwasser reviewed Mar 24, 2023
View reviewed changes
src/testRunner/unittests/services/utilities.ts
Comment on lines +6 to +7
const sourceFile = ts.createSourceFile("file.ts", `/// <reference path="./compiler.d.ts" />

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need the triple slash reference?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, probably not.

@jakebailey jakebailey merged commit a26175b into microsoft:main Apr 12, 2023
@jakebailey jakebailey deleted the fix-53476 branch April 12, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser left review comments

@sandersn sandersn sandersn approved these changes

@andrewbranch andrewbranch Awaiting requested review from andrewbranch

Assignees

@jakebailey jakebailey

Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Infinite loop getting completions when finding preceding matching token in JSDoc
4 participants
@jakebailey @typescript-bot @DanielRosenwasser @sandersn