-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Ensure findPrecedingToken recurses into JSDoc children when needed #53487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
import * as ts from "../../_namespaces/ts"; | ||
|
||
describe("unittests:: services:: utilities", () => { | ||
describe("Test findPrecedingMatchingToken,", () => { | ||
it("should not infinite loop finding opening brace", () => { | ||
const sourceFile = ts.createSourceFile("file.ts", `/// <reference path="./compiler.d.ts" /> | ||
|
||
(/** @window => { | ||
/** @type {Abcd123} */ | ||
const core = window.Abcd.core; | ||
})();`, ts.ScriptTarget.ESNext, /*setParentNodes*/ true); | ||
// can't use ts.getTokenAtPosition because it returns back the wrong token | ||
const param = ts.forEachChildRecursively(sourceFile, node => node.kind === ts.SyntaxKind.Parameter ? node : undefined)!; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what parameter is there in the example code? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. oh, There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No idea, I just copied and pasted the test from the issue... |
||
const jsDoc = param.getChildren()[0]; | ||
const token = jsDoc.getLastToken()!; | ||
const result = ts.findPrecedingMatchingToken(token, ts.SyntaxKind.OpenBraceToken, sourceFile); | ||
assert.isDefined(result); | ||
}); | ||
}); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you need the triple slash reference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, probably not.