-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Drop deferredNodes
after checking them all.
#52606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@typescript-bot perf test this faster |
Heya @DanielRosenwasser, I've started to run the abridged perf test suite on this PR at 8bc58c0. You can monitor the build here. Update: The results are in! |
@DanielRosenwasser Here they are:Comparison Report - main..52606
System
Hosts
Scenarios
Developer Information: |
8bc58c0
to
a279740
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's weird, because we can end up building up the list of deferred nodes piecewise while doing work requested for random other files, but once the file's checked it's definitely safe to discard the list - we certainly won't be referring to it again, anyway. We could probably clear out our unused identifier cache post-source-file-check, too, if we were a bit smarter about how we went about regenerating a list of unused identifier diagnostics in getSuggestionDiagnostics
(it is basically redoing the checkUnusedIdentifiers
call in checkSourceFile
does, but reclassifying them as suggestions).
Test to see if we can free up some memory once a file is fully type-checked.
Based on comment from #52605 (comment)